+
Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

fix bug creating addons from already matched curse ids #295

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

tarkah
Copy link
Member

@tarkah tarkah commented Oct 24, 2020

Resolves issue with Altoholic brought up in Discord

Proposed Changes

  • Any folder with a curse id that is already successfully mapped via an exact fingerprint match shouldn't allow a new addon to be created from that curse id. I've fixed a logic gap that allowed this to happen previously.

Checklist

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users

@tarkah tarkah changed the base branch from master to development October 24, 2020 16:14
@tarkah tarkah requested a review from casperstorm October 24, 2020 16:14
@tarkah
Copy link
Member Author

tarkah commented Oct 24, 2020

@mlablah This fixes the issue brought up this morning in discord for Altoholic

@tarkah tarkah changed the title Fix/nonmatch curseid gap fix bug creating addons from already matched curse ids Oct 24, 2020
Copy link
Member

@casperstorm casperstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! You can merge once you are ready.

@tarkah tarkah merged commit 1b907bc into development Oct 24, 2020
@tarkah tarkah deleted the fix/nonmatch-curseid-gap branch October 24, 2020 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载