This repository was archived by the owner on Sep 17, 2024. It is now read-only.
feat: date released column #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntwj
reviewed
Oct 20, 2020
| @@ -258,9 +258,12 @@ impl Addon { | |||
| let version = package.version.clone(); | |||
| let download_url = package.url.clone(); | |||
|
|
|||
| let date_time = NaiveDateTime::parse_from_str(&package.lastupdate, "%Y-%m-%d") | |||
| let date_time = NaiveDateTime::parse_from_str(&package.lastupdate, "%Y-%m-%d %H:%M:%S") | |||
| .map_or( | |||
There was a problem hiding this comment.
Does it make sense to use Result::map_or_else here to avoid parsing a second time if it succeeds the first time. My understanding is this will parse twice every time, even if the first is successful.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #210
Proposed Changes
Checklist
CHANGELOG.mdif knowledge of this change could be valuable to users