This repository was archived by the owner on Sep 17, 2024. It is now read-only.
feat/changelog #253
Merged
feat/changelog #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperstorm
commented
Oct 15, 2020
| @@ -62,9 +62,10 @@ impl std::fmt::Display for AjourMode { | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone)] | |||
| #[allow(clippy::large_enum_variant)] | |||
There was a problem hiding this comment.
@tarkah Clippy think we are using too big enum now. I ignored it. I think it's because we have Addon inside. You think it's gonna be a problem?
There was a problem hiding this comment.
I think it's fine until we finally get around to refactoring the entire GUI module where we can figure out how to better break everything up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #93
Proposed Changes
It is now possible to press on
localorremoteversion to view a changelog.Checklist
CHANGELOG.mdif knowledge of this change could be valuable to users