+
Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

TukUI addon using title from toc #326

@mlablah

Description

@mlablah

Describe the bug
I am using Ajour 0.5.0 from the Development branch.

This is a combination of two issues. One revealing the other.

A tukui addon called ElvUI_AbsorbTags appears with web color codes in the title after being installed.

ElvUI cff83F3F7Absorb Tags

From the toc file it looks like this: ## Title: |cff1784d1ElvUI |cff83F3F7Absorb

So it appears as though the first web color tag has been removed but the second hasn't. Possibly due to its use of mixed upper/lower case hexadecimal characters.

However we should only use the title from the toc file as a fallback for unrecognized addons. So the bigger issue is why is it even using the title from the toc file and not the name from the api?

Here is the api results for that addon: https://www.tukui.org/api.php?addon=85
And here is the title as it appears on the website: https://www.tukui.org/addons.php?id=85

Notice both have a name with an underscore and no color codes.

From the cache (addons.yml), the addon looks like this:

V1:
  Retail:
    - title: ElvUI cff83F3F7Absorb Tags
      repository: Tukui
      repository_id: "85"
      primary_folder_id: ElvUI_AbsorbTags
      folder_names:
        - ElvUI_AbsorbTags
      modified: "2020-10-31T23:00:45.692779100Z"

So it seems we save the (partially cleaned) toc title instead of the name from the api, as the title.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Catalog
  2. Search for and install the retail addon ElvUI_AbsorbTags using TukUI source.
  3. Go to My Addons and see the title contains web color code.

Expected behavior
That the addon was using title as listed in api response. Or failing that, using a fully cleaned version of title from toc.

Screenshots
unknown

Software involved
Please complete the following information:

  • OS: Windows 10
  • Ajour version: 0.5.0 from development branch.

Log Output
ajour.log

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载