+
Skip to content

Create configs.rst #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025
Merged

Create configs.rst #343

merged 3 commits into from
Jul 9, 2025

Conversation

juha-aiven
Copy link
Contributor

@juha-aiven juha-aiven commented Jul 8, 2025

Add Gradle task :storage:inkless:genInklessConfigDoc that generates the file docs/inkless/configs.rst documenting Inkless-specific configuration parameters. The task executes aiven.inkless.doc.ConfigsDocs.

Make :storage:inkless:build depend on genInklessConfigDoc to automatically generate the config.rst.

Add Gradle task :storage:inkless:genInklessConfigDoc that generates the file docs/inkless/configs.rst documenting Inkless-specific configuration parameters. The task executes aiven.inkless.doc.ConfigsDocs.
@juha-aiven juha-aiven requested a review from jeqo July 8, 2025 07:08
@juha-aiven juha-aiven marked this pull request as ready for review July 8, 2025 07:25
Copy link
Contributor

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This a good starting point. I wonder how we could add the Topic config as well.

Maybe let's add a CONFIG.md that documents manually the topic configs (inkless.enable and server default log.inkless.enable), and links to the broker-configs configs.rst; wdyt?

@@ -2468,6 +2468,19 @@ project(':storage:inkless') {
outputs.dir("${projectDir}/build/generated/main/java/io/aiven/inkless/generated")
}

task genInklessConfigDoc(type: JavaExec) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what's the best way to link this into the build process, so it doesn't get outdated.

In TS we used "finalizedBy" to do it after compilation: https://github.com/Aiven-Open/tiered-storage-for-apache-kafka/blob/8a98bcc8ad3dd0be026a55a85ede1dce8a703782/docs/build.gradle#L55-L57

Another option is to have it as part of the release process, and include it on siteDocsTar but we are not publishing docs so maybe not too useful.

Make :storage:inkless:build depend on genInklessConfigDoc to automatically generate the config.rst.
@juha-aiven
Copy link
Contributor Author

I wonder what's the best way to link this into the build process, so it doesn't get outdated.

Good point. Now :storage:inkless:build recreates the config.rst-file. It's not perfect but anybody who's building the project locally should eventually notice the config.rst is out of date if it goes out of date.

@juha-aiven
Copy link
Contributor Author

This a good starting point. I wonder how we could add the Topic config as well.
Maybe let's add a CONFIG.md that documents manually the topic configs (inkless.enable and server default log.inkless.enable), and links to the broker-configs configs.rst; wdyt?

Sounds quite good. I'll have a look at this. Also, the metrics need to be documented, I'll check that too.

@juha-aiven juha-aiven requested a review from jeqo July 8, 2025 11:41
@juha-aiven
Copy link
Contributor Author

This a good starting point. I wonder how we could add the Topic config as well.
Maybe let's add a CONFIG.md that documents manually the topic configs (inkless.enable and server default log.inkless.enable), and links to the broker-configs configs.rst; wdyt?

Sounds quite good. I'll have a look at this. Also, the metrics need to be documented, I'll check that too.

There's now #344 for the topic config.

@jeqo jeqo merged commit 00dfeff into main Jul 9, 2025
3 checks passed
@jeqo jeqo deleted the generate-config-doc branch July 9, 2025 06:21
@jlprat
Copy link
Member

jlprat commented Jul 9, 2025

I'm late to the party, but why an rst file and not and md one?

@juha-aiven
Copy link
Contributor Author

I'm late to the party, but why an rst file and not and md one?

One reason is that ConfigDef-class has built in support for generating rst, see

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载