-
Notifications
You must be signed in to change notification settings - Fork 51
Improve wording of contract error messages #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
contract/vm_callback.go
Outdated
} | ||
if pubKey == nil { | ||
luaPushStr(L, "[Contract.LuaEcVerify]not supported") | ||
luaPushStr(L, "[Contract.LuaEcVerify] pubKey cannot be empty") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pubKey is not input. this error caused by invalid or unsupported address format that can not get pubkey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is "error recovering pubKey" ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Thanks for catching those, I added another commit. |
* [ctr/lua]add contract.deploy - contract.deploy.value()(src or address) * [ctr/lua] bug fix about contract.pcall * [SYNCER] syncer stop if sync has already done before executing finder * [ctr/lua] Enable the db module when private net * [fix] Enable the db module when private net * [ctr/lua] changed to fail transaction when error occured at constructor function * [state] fix commit timing of contract storage - change not to commit contract storage during the update phase - use bulktx mode only - refine code * [ctr/lua] Fix invalid use of type assertion * [CHAIN] fit to add only blocks that have error during execution to error cache * [ctr/lua] minor bug fix for preload - change to prevent error when sending tx with payload to non-contract account * [SYNCER] add logic for recovering panic in syncer, finder, blockfetcher, hashfetcher * [SYNCER] fix not to call old version of sync logic * [P2P][RPC] Show hidden peer on GetPeers command - Normally RPC is used by admin * [ctr/lua] Remove type assertion when processing VmError * [P2P] Remove unsed legacy code - Codes for old sync algorithm * [chore] Update luajit * [chain] fix genensis BP list * Improve wording of contract error messages (#34) * [CLI] Update version information * [dpos] update BP list upon a reorganization * [consensus] verify block right before execution - The early block verification prevents a valid reorganization. - bugfix: addBlock method had mistakenly returned nil except when the block is pushed into the error block cache so that error was silently ignored. * [consensus] add VerifySign to Consensus - For early rejection of a invalid block * [state] add function to get initial data from contract storage * [state] add testcode to get initial data from contract storage * Correct usage message for genesis init * [CLI] Change command for staking, unstaking * Fix usage string for aergosvr init and change votestat default count to 23 * [ctr/lua] changed encoding of table object to sort by key * [CHAIN] fix not to use mempool in signverifier if sync is in progress - process timeout error of mempool as cache miss - add skipmempool flag in signverifier - remove minor warning * [P2P] Fix occuring dead letter - Fix wrong call to actor * [CLI] Check name length before sending to aergosvr - Add validation in mempool, too * [POLAR] Fix wrong connect to default polaris - Compare chainID with aergo's official mainnet and testnet - connecting default polaris server is only enabled when chainid is matching at startup. * Add version command in aergosvr * test travis deployment (#35) * [name] Refactor code for varification (#36) Tx to create, update name will take effect after mining block. * [chain] fix nil block in genesis info * [chore] Upgrade luajit to v2.1.0-beta3 * [ctr/lua] patch for testnet about constructor fail * [ctr/lua] patch for panic when returning userdata in contract * Revert "[ctr/lua] patch for testnet about constructor fail" This reverts commit 3fcd8cc. * [POLAR] Change default behaviors of polaris - Polaris will return peer list and success status even if registering peer is failed. - Since previous behavior confused many users. * [P2P] Add support for domain name - receive peer information of domain name instead of ip address - connect peer with domain name * [P2P] Fix unit test failure - Remove envirionment dependent test case * [name] Now, need to pay 1 aergo for creating name * [name] Takes 1aergo to update name. Just like creating (#38) * Fix handshake failure bug (#39) * [name] Takes 1aergo to update name. Just like creating * [P2P] Fix handshake failed in default configuration - Didn't set address in default config (empty address value) * [proof] update storage key in state queries * [staking,voting] Change encoder to protobuf when save in trie (#40) * [ctr/lua] Prevent access to state db when loading bytecode * [system contract] Remove gob and implements serialization * [staking] Fix serialization - Add missing from f23da63b0d1 * Hotfix/0.10 deadlock (#43) * [P2P] Fix occational deadlock when too much tx notices - Refactor stop process of remote peer, which caused deadlock in some heavy load condition. - Fix deadlock in stop channel - Change to not non-blocking manner. - Move role to manage net.Stream to remote peer from peer manager - Add ManageNumber to track peer connection. * [P2P] Fix occational deadlock when too much tx notices - Refactor stop process of remote peer, which caused deadlock in some heavy load condition. - Change concurrent model of removing peer from channel based to mutex - Fix deadlock in stop channel - Change to not non-blocking manner. - Move role to manage net.Stream to remote peer from peer manager - Add ManageNumber to track peer connection.
No description provided.