+
Skip to content

Conversation

aspiers
Copy link
Contributor

@aspiers aspiers commented Feb 9, 2020

Always return non-zero exit code on error for consistency. This ensures that if brick is called from within shell scripts / Makefiles etc., errors can be properly detected and handled.

Always return non-zero exit code on error for consistency.  This
ensures that if brick is called from within shell scripts /
Makefiles etc., errors can be properly detected and handled.
@graup graup requested a review from sunpuyo February 10, 2020 05:55
Returning a return code is a good idea.
However, I modified the code a bit, because when you reset the `batchErrorCount` at the beginning, the error count was initialized when another batch file is called from the module called batch, so I removed all the code that initialized the `batchErrorCount`.
And at the end of the print, error is already printed like 'Batch is failed: Error <err number>'. Right now It is confused by printing an error every time the batch level changes.
reset errorCount for interactive mode and keep last error count for batch mode
@graup
Copy link
Member

graup commented Feb 21, 2020

@sunpuyo do you want to merge this for 2.2? We're going to make the release branch soon.

@sunpuyo sunpuyo merged commit 21dc986 into aergoio:develop Feb 21, 2020
@sunpuyo
Copy link
Contributor

sunpuyo commented Feb 21, 2020

@graup Yes, this issue is completed and I merge this.

@aspiers aspiers deleted the brick-exit-code branch April 13, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载