add example for nonlinear viscoelasticity #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bhaveshshrimali, thanks! Are my additions to the example fine for you? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #780 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 137 137
Lines 5445 5445
=======================================
Hits 5311 5311
Misses 134 134 ☔ View full report in Codecov by Sentry. |
|
Hi @adtzlr , Looks perfect to me. Thanks for the description. I just added a link to the implementation (not unique since that is how it has been solved in Reese & Govindjee and many others) for the model. Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @adtzlr ,
Sorry for the delay, but here is the example as you had suggested in #666 (comment)
Please let me know if you need me to work on any additions/edit. I'm coming back to felupe after a while, and as always happy to see the examples expanding continuously.
Thanks,
Bhavesh