+
Skip to content

Conversation

chvp
Copy link
Member

@chvp chvp commented Jul 23, 2021

If a play was not reported due to a network error, it is saved to the local database and retried when the next play is (successfully) reported.

Fixes #199.

Tested the following scenario's:

  • Transitioning from one track to the next should create a play.
  • Transitioning from one track to itself (on repeat) should create a play.
  • Skipping to the next track should not create a play.
  • Stopping playback should not create a play.
  • Playback stopping due to the end of the playlist being reached naturally should create a play.

@chvp chvp added the enhancement New feature or request label Jul 23, 2021
@chvp chvp enabled auto-merge (squash) July 23, 2021 15:37
@chvp chvp merged commit c0abde7 into main Jul 23, 2021
@chvp chvp deleted the feature/report-plays branch July 23, 2021 15:41
@robbevp
Copy link
Member

robbevp commented Jul 23, 2021

@chvp What happens if the player can't cache the full track (due to network error or similar?)

@chvp
Copy link
Member Author

chvp commented Jul 23, 2021

Caching and play reporting are not really related to each other. If the full track can't be played due to caching/network errors, then the play will not be reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report plays

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载