+
Skip to content

CRAVEX Jira workflow integration #350 #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 7, 2025
Merged

CRAVEX Jira workflow integration #350 #375

merged 15 commits into from
Aug 7, 2025

Conversation

tdruez
Copy link
Contributor

@tdruez tdruez commented Aug 4, 2025 •
edited
Loading

Issue: #350

Documentation

https://dejacode.readthedocs.io/en/latest/integrations-jira.html

Changes

  • Add a jira_user and a jira_token field on the Dataspace configuration model.
  • The integration code exists as the JiraIntegration class.
  • Add full test suite for the Jira integration.
  • Refactor the integrations module organization
  • Add form validation for the issue_tracker_id value.
  • Add logging for failed requests.
  • Refactor the HTTP request system on the BaseIntegration class (migrate GitHub and GitLab integrations to the new system).
  • Refine support for 204 No Content responses.
  • Use raw_update in link_external_issue.

DejaCode configuration

Refer to https://dejacode.readthedocs.io/en/latest/integrations-jira.html for detailed instructions.

Notes

  • Jira integration requires a bit more setup: The proper "Work type" and "Status" need to be configured first.

@tdruez
Add Jira workflow Request integration #350
833713a 
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Copy link
Contributor Author

tdruez commented Aug 4, 2025

@DennisClark This PR is still a work in progress but you're welcome to give it a try and provide some feedback.

@DennisClark
Copy link
Member

Here is my Jira Project.

https://aboutcode-dejacode.atlassian.net/jira/servicedesk/projects/AD/queues/custom/4

I just added an invite to you

https://aboutcode-dejacode.atlassian.net/jira/servicedesk/projects/AD/customers

tdruez added 7 commits August 5, 2025 12:14
@tdruez
Refactor the integrations module organization #350
a3013af 
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Fix the issue url link for Jira #350
c66b5f1 
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Add form validation for the issue_tracker_id value #350
b0fbf65 
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Enhance the Jira URL support #350
09a63a3 
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Add JiraIntegrationTestCase class #350
4c64ea1 
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Add logging for failed POST requests #350
46b3fdb 
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Add custom work type requirement #350
9c8b194 
Signed-off-by: tdruez <tdruez@nexb.com>
@aboutcode-org aboutcode-org deleted a comment from DennisClark Aug 5, 2025
tdruez added 6 commits August 6, 2025 11:50
@tdruez
Refactor the HTTP request on BaseIntegration #350
57a7ea2 
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Refine support for 204 No Content response #350
5bba4a0 
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Use raw_update in link_external_issue #350
32619c0 
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Migrate GitHub abd GitLab integrations to new request system #350
7d1f1b6 
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Fix unit tests #350
8346231 
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Add "Create Done Status" in docs #350
9d2befe 
Signed-off-by: tdruez <tdruez@nexb.com>
@DennisClark
Copy link
Member

@tdruez I am not able the edit the Workflow on my DejaCode Request Issue Type, because it is defined with the "system" workflow called simply Jira which has a final status of Closed rather than Done. So I'm stuck I think.

Perhaps we should send a Closed status to Jira instead of Done, especially since the Closed status is probably a convention for all (or at least most) Jira implementations since it is automatically provided with the default system workflow.

@DennisClark
Copy link
Member

See screenshot

Jira system workflow

@DennisClark
Copy link
Member

oh, and maybe it needs to be CLOSED rather than Closed since I don't know if it is case-sensitive or not.

@tdruez
Update the status to Closed #350
46bbac4 
Signed-off-by: tdruez <tdruez@nexb.com>
@DennisClark
Copy link
Member

DennisClark commented Aug 6, 2025 •
edited
Loading

@tdruez Retesting shows progress; however, Closing the DejaCode Request passed the closing comment successfully, but the status in Jira is, surprisingly, "Reopened" -- I don't understand that.

https://aboutcode-dejacode.atlassian.net/browse/AD-3

@DennisClark
Copy link
Member

Another Jira link of my requests-to-date:
https://aboutcode-dejacode.atlassian.net/jira/servicedesk/projects/AD/queues/custom/4

It includes one that I created manually (with a different workflow), but the other two came from DejaCode.

@tdruez tdruez merged commit 65b4f55 into main Aug 7, 2025
4 checks passed
@tdruez tdruez deleted the 350-jira-integration branch August 7, 2025 09:41
@tdruez tdruez mentioned this pull request Aug 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tdruez @DennisClark
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载