-
-
Notifications
You must be signed in to change notification settings - Fork 14
Add the ability to delete a Scan from Product inventory #222 #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez Testing in Staging Starship. I opened a Product Inventory and clicked on the Delete icon on one of the Scans. I got the are-you-sure prompt and continued. The UI gets a bit confusing at that point. The application presents the Scans page, which is kind of ok but I have to use my browser back button to get back to the Product Inventory page, which is not refreshed and still has the are-you-sure prompt displayed and of course it doesn't work to try deleting a second time. So basically I think we need some kind of return-to-product-inventory link/button that takes the user back to a refreshed product inventory display. |
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
@DennisClark Thanks for the feedback, the navigation was indeed confusing. I've refined the whole implementation so one can now trigger scans and delete existing scans (fail one for example) from the inventory table without being redirected. Everything should be much more dynamic now, as scan progress is rendered in the table cell following the scan request. You can now give it another try ;) |
@tdruez Interesting results in Staging Starship. I opened Product Then I decided to test the inventory package just below that, So I'm guessing that the problems I encountered are primarily due to the need for some kind of data/state refresh on the product inventory page. I am using Firefox. |
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez I'll try to reproduce the Error(s) I encountered and get back to you. |
Hi @tdruez I have now added the package |
@DennisClark Thanks for the details, this is a side effect of an issue on the ScanCode.io side, entered as aboutcode-org/scancode.io#1669 |
@DennisClark The ScanCode.io issue is now fixed, see aboutcode-org/scancode.io#1669 |
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez it's working perfectly now, thanks! |
Changes:
This should help to mitigate the issue described at #222 as you can easily see the scan failures from that list, delete and rescan as well.