+
Skip to content

Conversation

tdruez
Copy link
Contributor

@tdruez tdruez commented Mar 11, 2025

Changes:

  1. Display Scan status and action, as a table column, in Product inventory table.
  2. Add the ability to delete a Scan from Product inventory table.

This should help to mitigate the issue described at #222 as you can easily see the scan failures from that list, delete and rescan as well.

Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez tdruez changed the title Add the ability to delete a Scan from Product inventory #230 Add the ability to delete a Scan from Product inventory #222 Mar 11, 2025
tdruez added 4 commits March 11, 2025 18:38
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
@DennisClark
Copy link
Member

@tdruez Testing in Staging Starship. I opened a Product Inventory and clicked on the Delete icon on one of the Scans. I got the are-you-sure prompt and continued. The UI gets a bit confusing at that point. The application presents the Scans page, which is kind of ok but I have to use my browser back button to get back to the Product Inventory page, which is not refreshed and still has the are-you-sure prompt displayed and of course it doesn't work to try deleting a second time. So basically I think we need some kind of return-to-product-inventory link/button that takes the user back to a refreshed product inventory display.

tdruez added 5 commits March 12, 2025 15:08
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Copy link
Contributor Author

tdruez commented Mar 12, 2025

@DennisClark Thanks for the feedback, the navigation was indeed confusing.

I've refined the whole implementation so one can now trigger scans and delete existing scans (fail one for example) from the inventory table without being redirected. Everything should be much more dynamic now, as scan progress is rendered in the table cell following the scan request.

You can now give it another try ;)

@DennisClark
Copy link
Member

@tdruez Interesting results in Staging Starship. I opened Product CargoManager 2.8.4 and observed that there no scan results presented for any of the Inventory packages, so I scrolled down to pkg:pypi/aboutcode-toolkit@7.2.0 and clicked the Scan button, which went fine, and showed a nice progress bar; however, the display does not refresh when the scan is done -- I noticed that the scan was successful on the main "Scans" form and after I returned to the Product Inventory form and used the browser to refresh the page it showed the current successful state and I was able to access it.

Then I decided to test the inventory package just below that, pkg:pypi/amqp@2.6.1 and first I opened the package record itself to take a look and I clicked the Download URL on it and that was successful. So back on the Product Inventory page I clicked the Scan button and got an Error! displayed in the Scan field but had no way to determine what that error might be. I discovered that if I click on any other Scan button I get a dialog that shows Error fetching in one of the buttons and there is not much else I can do about it.

So I'm guessing that the problems I encountered are primarily due to the need for some kind of data/state refresh on the product inventory page. I am using Firefox.

tdruez added 2 commits May 9, 2025 17:48
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
@DennisClark
Copy link
Member

@tdruez I'll try to reproduce the Error(s) I encountered and get back to you.

@DennisClark
Copy link
Member

Hi @tdruez I have now added the package pkg:pypi/amqp@2.6.1 to the product Starship Data Explorer 4.2.5 in the nexB dataspace in both production and staging. You can reproduce the problem by opening that product, scrolling through the inventory to get to that package, and clicking the Scan button in that row, and you'll get the mysterious Error! and not much else. There is probably something in the scan results (or something missing) that is triggering the problem. Thanks for investigating this.

@tdruez
Copy link
Contributor Author

tdruez commented May 13, 2025

@DennisClark Thanks for the details, this is a side effect of an issue on the ScanCode.io side, entered as aboutcode-org/scancode.io#1669

@tdruez
Copy link
Contributor Author

tdruez commented May 13, 2025

@DennisClark The ScanCode.io issue is now fixed, see aboutcode-org/scancode.io#1669
You can give it another try ;)

Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez tdruez merged commit 925d404 into main May 13, 2025
3 of 4 checks passed
@tdruez tdruez deleted the 222-product-scans branch May 13, 2025 13:11
@DennisClark
Copy link
Member

@tdruez it's working perfectly now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载