Use deterministic UID/GID in Dockerfile #230 #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tdruez <tdruez@nexb.com>
|
Looks good to me as a workaround. Hopefully the chown will no longer be necessary once people have migrated to a version which has run it at least once. So for a future release this could then be removed again and if people are still using an older version, they should upgrade to the release with the chown first, followed by an upgrade to the most recent version. That seems like a sensible upgrade path to me. |
… used #230 Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #230
Similar implementation as https://github.com/aboutcode-org/scancode.io/pull/1569/files including feedback from aboutcode-org/scancode.io#1555 (comment)
@ghsa-retrieval let me know your take on this implementation.