-
-
Notifications
You must be signed in to change notification settings - Fork 14
Store additional license fields #63 #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
The latest addition as of June 19th:
|
@tdruez the latest features look good on Staging, no problems found. |
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
The latest addition as of June 27th:
@DennisClark that addition should complete the implementation. The last thing no implemented is the ability to render those new fields as SPDX. I've started to work on it but it will require a refactor of the license expression system. |
@tdruez Question please: how does a value get populated into "Other license expression"? I did a rather complicated create-package-scan from https://github.com/apache/nifi/archive/refs/tags/rel/nifi-2.0.0-M3.tar.gz in Staging Starship and it seemed to work just fine, except that there is nothing in the "Other license expression" field even though there are lots of "other_license_expressions" returned in the scan results. Shouldn't there be a process to combine and de-dupe those into a single expression? this is another one that we can defer so that you can go ahead and merge/deploy progress-to-date but we should give it some consideration soon. |
@tdruez regarding my previous comment, I created a new package in Staging Starship from the PurlDB using |
@tdruez I successfully tested all the new features you mention (except the new-component-from-package problem mentioned above) but I have one concern about the UI. Is it possible, and practical, to present the individual licenses in "Declared license expression" and "Other license expression" with links to the DejaCode license definitions? Also is it possible to show the Usage Policy icon? See attached screenshot. |
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Correct, it was taken from the PurlDB.
That error is now fixed.
Yes, I've added proper rendering, link, and policy, for the new fields. Also, I've managed to implement the SPDX rendering for all license_expression fields. In Reporting, there are 3 new properties available on Component and Package: |
@tdruez all my concerns are addressed in the latest Staging Starship. No problems found. Everything looks good and ready to go, thanks. |
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Added 2 new license related fields on the
Component
andPackage
models:declared_license_expression
other_license_expression
Added 2 properties on the
Component
andPackage
models:declared_license_expression_spdx
(computed fromdeclared_license_expression
)other_license_expression_spdx
(computed fromother_license_expression
)Removed 2 fields:
Package.declared_license
Component.concluded_license
The new fields are available in
Component
andPackage
:Set "Concluded license expression" for the
license_expression
fields verbose name onComponent
,Package
,ProductComponent
, andProductPackage
fields. (Not applied toProduct
andSubcomponent
).Update all legacy
license_expression
help textsThe new fields are now displayed (when a value is available) in "Scan" tab "DETECTED PACKAGE" section and the directly related "Set value to Package" form. Note that if the
declared_license_expression
is available in the Scan data, and thelicense_expression
is empty on the Package instance, thelicense_expression
(concluded) will be set with thedeclared_license_expression
value.