oravirt · Rendanic · Aug 27, 2024 · Aug 27, 2024 · Aug 27, 2024
diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml
@@ -18,4 +18,4 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Run ansible-lint
-        uses: ansible/ansible-lint@v6.22.1
+        uses: ansible/ansible-lint@v24.7.0
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -50,7 +50,7 @@ repos:
           - ansible-core
 
   - repo: https://github.com/ansible-community/ansible-lint.git
-    rev: v6.22.1
+    rev: v24.7.0
     hooks:
       - id: ansible-lint
         entry: ansible-lint --force-color -p

diff --git a/changelogs/fragments/ansible-lint.yml b/changelogs/fragments/ansible-lint.yml
@@ -0,0 +1,3 @@
+---
+minor_changes:
+  - "ansible-lint: Update ansible-lint to 24.7.0 (oravirt#471)"
diff --git a/changelogs/fragments/ansible-lint2.yml b/changelogs/fragments/ansible-lint2.yml
@@ -0,0 +1,3 @@
+---
+minor_changes:
+  - "ansible-lint: fqcn[action-core] for ansible.builtin.yum due to OL7 compatibility (oravirt#471)"
diff --git a/example/rac/ansible/playbooks/os_racattack.yml b/example/rac/ansible/playbooks/os_racattack.yml
@@ -28,7 +28,7 @@
           {% endfor %}
 
     - name: List availible updates
-      ansible.builtin.yum:
+      ansible.builtin.yum:  # noqa fqcn[action-core]
         list: updates
         update_cache: true
         security: true
@@ -40,7 +40,7 @@
         var: yum_update_list_res.results | map(attribute='name') | sort
 
     - name: Update all OS packages to latest
-      ansible.builtin.yum:  # noqa: package-latest
+      ansible.builtin.yum:  # noqa: package-latest fqcn[action-core]
         name: '*'
         state: latest
         lock_timeout: 600

diff --git a/roles/common/tasks/RedHat.yml b/roles/common/tasks/RedHat.yml
@@ -11,7 +11,7 @@
         key: https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-{{ ansible_distribution_major_version }}
 
     - name: Add EPEL Repo
-      ansible.builtin.yum:
+      ansible.builtin.yum:  # noqa fqcn[action-core]
         name: "{{ _common_epel_rpm }}"
         state: installed
 
@@ -43,7 +43,7 @@
     - olrepo
 
 - name: Install common packages OL/RHEL
-  ansible.builtin.yum:
+  ansible.builtin.yum:  # noqa fqcn[action-core]
     name: "{{ common_packages }}"
     state: installed
   when:

diff --git a/roles/orahost/tasks/RedHat.yml b/roles/orahost/tasks/RedHat.yml
@@ -1,7 +1,7 @@
 ---
 # OL8/RHEL8 has all needed RPMs in orahost role!
 - name: Install packages required by Oracle on OL/RHEL version 6,7,8,9
-  ansible.builtin.yum:
+  ansible.builtin.yum:  # noqa fqcn[action-core]
     name: "{{ oracle_packages }}"
     state: installed
     enablerepo: "{{ extrarepos_enabled | default(omit, True) }}"
@@ -13,7 +13,7 @@
   notify: Reboot concerning package updates
 
 - name: Install packages required by Oracle for ASMlib on OL/RHEL
-  ansible.builtin.yum:
+  ansible.builtin.yum:  # noqa fqcn[action-core]
     name: "{{ oracle_asm_packages }}"
     state: installed
     enablerepo: "{{ extrarepos_enabled | default(omit, True) }}"
@@ -30,7 +30,7 @@
     - disable_firewall
   block:
     - name: Check if firewall is installed
-      ansible.builtin.yum:
+      ansible.builtin.yum:  # noqa fqcn[action-core]
         list: "{{ firewall_service }}"
         disablerepo: "*"
       tags: iptables,firewalld

diff --git a/roles/oraswgi_install/tasks/12.1.0.1.yml b/roles/oraswgi_install/tasks/12.1.0.1.yml
@@ -26,7 +26,7 @@
 
 - name: install_home_gi | Install cvuqdisk rpm
   # noqa ignore-errors
-  ansible.builtin.yum:
+  ansible.builtin.yum:  # noqa fqcn[action-core]
     name: "{{ oracle_stage_install }}/{{ oracle_install_version_gi }}/grid/rpm/{{ cvuqdisk_rpm }}"
     state: present
   when: _oraswgi_meta_configure_cluster

diff --git a/roles/oraswgi_install/tasks/12.1.0.2.yml b/roles/oraswgi_install/tasks/12.1.0.2.yml
@@ -27,7 +27,7 @@
   when: oracle_home_gi not in checkgiinstall.stdout and oracle_install_version_gi == item.version and not oracle_sw_copy and oracle_sw_unpack
 
 - name: install_home_gi | Install cvuqdisk rpm
-  ansible.builtin.yum:
+  ansible.builtin.yum:  # noqa fqcn[action-core]
     name: "{{ oracle_stage_install }}/{{ oracle_install_version_gi }}/grid/rpm/{{ cvuqdisk_rpm }}"
     state: present
   # noqa ignore-errors

diff --git a/roles/oraswgi_install/tasks/12.2.0.1.yml b/roles/oraswgi_install/tasks/12.2.0.1.yml
@@ -49,7 +49,7 @@
     - _orasw_meta_primary_node | bool
 
 - name: install_home_gi | Install cvuqdisk rpm
-  ansible.builtin.yum:
+  ansible.builtin.yum:  # noqa fqcn[action-core]
     name: "{{ oracle_home_gi }}/cv/rpm/{{ cvuqdisk_rpm }}"
     state: present
   # noqa ignore-errors

diff --git a/roles/oraswgi_install/tasks/18.3.0.0.yml b/roles/oraswgi_install/tasks/18.3.0.0.yml
@@ -53,7 +53,7 @@
     - _orasw_meta_primary_node | bool
 
 - name: install_home_gi | Install cvuqdisk rpm
-  ansible.builtin.yum:
+  ansible.builtin.yum:  # noqa fqcn[action-core]
     name: "{{ oracle_home_gi }}/cv/rpm/{{ cvuqdisk_rpm }}"
     state: present
   # noqa ignore-errors

diff --git a/roles/oraswgi_install/tasks/19.3.0.0.yml b/roles/oraswgi_install/tasks/19.3.0.0.yml
@@ -98,7 +98,7 @@
       tags: cvuqdisk
 
     - name: include 19c/21c | Install cvuqdisk rpm
-      ansible.builtin.yum:
+      ansible.builtin.yum:  # noqa fqcn[action-core]
         name: "{{ oracle_rsp_stage }}/{{ cvuqdisk_rpm }}"
         state: present
         disable_gpg_check: true

diff --git a/tools/dev/requirements_dev.txt b/tools/dev/requirements_dev.txt
@@ -14,7 +14,7 @@
 #
 ansible-core<2.17
 ansible-builder==3.1.0
-ansible-lint==6.22.1
+ansible-lint==24.7.0
 ansible-navigator==24.8.0
 pre-commit==3.4.0