oravirt · Rendanic · Mar 6, 2024 · Mar 5, 2024 · Mar 5, 2024 · Mar 5, 2024
diff --git a/changelogs/fragments/fix_loops.yml b/changelogs/fragments/fix_loops.yml
@@ -0,0 +1,10 @@
+---
+bugfixes:
+  - "oradb_facts: Loop gathered facts only for first database from oracle_databases (oravirt#416)"
+  - "oradb_facts: Prevent re-using results from previous loop run when ignore_errors set to true (oravirt#416)"
+  - "oradb_manage_redo: Loop processed only first database from oracle_databases (oravirt#416)"
+  - "oradb_manage_statspack: Loops processed only first database/pdb from oracle_databases/oracle_pdbs (oravirt#416)"
+  - "oradb_rman: Loops processed only first database from oracle_databases (oravirt#416)"
+  - "orasw_meta_internal: replaced all odb[0]/opdb[0] with _odb_loop_helper/_opdb_loop_helper (oravirt#416)"
+  - "global: removed redundant flatten(levels=1) filter on oracle_database/oracle_pdbs (oravirt#416)"
+  - "global: replaced `match` filter fith `equalto` to prevent partial matches where not wanted (oravirt#416)"
diff --git a/roles/oradb_datapatch/tasks/main.yml b/roles/oradb_datapatch/tasks/main.yml
@@ -25,7 +25,7 @@
     state: started
   become: true
   become_user: "{{ oracle_user }}"
-  with_items: "{{ oracle_databases | selectattr('state', 'match', 'present') }}"
+  with_items: "{{ oracle_databases | selectattr('state', 'equalto', 'present') }}"
   loop_control:
     loop_var: odb
     label: >-
@@ -40,8 +40,8 @@
 - name: oradb_datapatch | Run datapatch
   opitzconsulting.ansible_oracle.oracle_datapatch:
     oracle_home: "{{ _oracle_home_db }}"
-    db_name: "{{ odb.0.oracle_db_name }}"
-    db_unique_name: "{{ odb.0.oracle_db_unique_name | default(omit) }}"
+    db_name: "{{ odb.oracle_db_name }}"
+    db_unique_name: "{{ odb.oracle_db_unique_name | default(omit) }}"
     sid: "{{ odb.oracle_db_instance_name | default(omit) }}"
     output: verbose
     fail_on_db_not_exist: "{{ oradb_datapatch_fail_on_db_not_exist }}"
@@ -50,17 +50,16 @@
     hostname: "{{ ansible_fqdn }}"
     service_name: "{{ _db_service_name }}"
     port: "{{ _listener_port_cdb }}"
-  loop:
-    - "{{ oracle_databases | selectattr('state', 'match', 'present') | flatten(levels=1) }}"
+  loop: "{{ oracle_databases | selectattr('state', 'equalto', 'present') }}"
   become: true
   become_user: "{{ oracle_user }}"
   loop_control:
     loop_var: odb
     label: >-
-      home: {{ odb.0.home | default('') }}
-      db_name: {{ odb.0.oracle_db_name | default('') }}"
+      home: {{ odb.home | default('') }}
+      db_name: {{ odb.oracle_db_name | default('') }}"
   when:
     - oracle_databases is defined
     - oracle_databases | list | length > 0
-    - odb.0.state == 'present'
+    - odb.state == 'present'
   tags: datapatch
diff --git a/roles/oradb_facts/tasks/db_facts.yml b/roles/oradb_facts/tasks/db_facts.yml
@@ -22,19 +22,19 @@
     cacheable: true
     oracledb_facts: "{{ oracledb_facts | default({}) | combine(_db_facts | items2dict) }}"
   when:
-    - ansible_facts['version'] is defined
+    - dbfactsreg.ansible_facts['version'] is defined
   vars:
     _db_facts:
-      - key: "{{ odb[0]['oracle_db_unique_name'] | default(odb[0]['oracle_db_name']) }}"
+      - key: "{{ odb['oracle_db_unique_name'] | default(odb['oracle_db_name']) }}"
         value:
-          version: "{{ ansible_facts['version'] }}"
-          database: "{{ ansible_facts['database'] }}"
-          instance: "{{ ansible_facts['instance'] }}"
-          pdb: "{{ ansible_facts['pdb'] }}"
-          parameter: "{{ ansible_facts['parameter'] }}"
-          rac: "{{ ansible_facts['rac'] }}"
-          redolog: "{{ ansible_facts['redolog'] }}"
-          tablespace: "{{ ansible_facts['tablespace'] }}"
-          temp_tablespace: "{{ ansible_facts['temp_tablespace'] }}"
-          userenv: "{{ ansible_facts['userenv'] }}"
-          option: "{{ ansible_facts['option'] }}"
+          version: "{{ dbfactsreg.ansible_facts['version'] }}"
+          database: "{{ dbfactsreg.ansible_facts['database'] }}"
+          instance: "{{ dbfactsreg.ansible_facts['instance'] }}"
+          pdb: "{{ dbfactsreg.ansible_facts['pdb'] }}"
+          parameter: "{{ dbfactsreg.ansible_facts['parameter'] }}"
+          rac: "{{ dbfactsreg.ansible_facts['rac'] }}"
+          redolog: "{{ dbfactsreg.ansible_facts['redolog'] }}"
+          tablespace: "{{ dbfactsreg.ansible_facts['tablespace'] }}"
+          temp_tablespace: "{{ dbfactsreg.ansible_facts['temp_tablespace'] }}"
+          userenv: "{{ dbfactsreg.ansible_facts['userenv'] }}"
+          option: "{{ dbfactsreg.ansible_facts['option'] }}"
diff --git a/roles/oradb_facts/tasks/main.yml b/roles/oradb_facts/tasks/main.yml
@@ -14,15 +14,14 @@
     # overwrites ansible_facts from the previous one
     - name: Gather Facts from Database
       ansible.builtin.include_tasks: db_facts.yml
-      loop:
-        - "{{ oracle_databases }}"
+      loop: "{{ oracle_databases }}"
       loop_control:
         loop_var: odb
         label: >-
-          db_name: {{ odb[0]['oracle_db_name'] | default('') }}
-          db_unique_name: {{ odb[0]['oracle_db_unique_name'] | default('') }}
+          db_name: {{ odb['oracle_db_name'] | default('') }}
+          db_unique_name: {{ odb['oracle_db_unique_name'] | default('') }}
           port: {{ _listener_port_cdb }}
           service: {{ _db_service_name }}
-          state: {{ odb[0]['state'] | default('present') }}
+          state: {{ odb['state'] | default('present') }}
       when:
-        - odb[0]['state'] | default('present') == 'present'
+        - odb['state'] | default('present') == 'present'
diff --git a/roles/oradb_manage_db/tasks/assert.yml b/roles/oradb_manage_db/tasks/assert.yml
@@ -23,9 +23,10 @@
     quiet: true
     fail_msg: "Missing element with listener_name in listener_installed!"
     that:
-      - listener_installed | default([])
-          | selectattr('listener_name', 'match', odb.listener_name)
-          | list | length == 1
+      - >-
+        listener_installed | default([])
+        | selectattr('listener_name', 'equalto', odb.listener_name)
+        | list | length == 1
   with_items: "{{ oracle_databases | selectattr('listener_name', 'defined') }}"
   register: assert2
   loop_control:

diff --git a/roles/oradb_manage_grants/tasks/main.yml b/roles/oradb_manage_grants/tasks/main.yml
@@ -64,7 +64,7 @@
     - opdb.0.state == 'present'
     - (opdb.1.grants is defined or opdb.1.object_privs is defined)
     - >-
-      oracle_databases | selectattr('oracle_db_name', 'match', opdb.0.cdb)
+      oracle_databases | selectattr('oracle_db_name', 'equalto', opdb.0.cdb)
       | map(attribute='state') | list | first == 'present'
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
   become: true
@@ -147,7 +147,7 @@
     - opdb.0.state == 'present'
     - (opdb.1.grants is defined or opdb.1.object_privs is defined)
     - >-
-      oracle_databases | selectattr('oracle_db_name', 'match', opdb.0.cdb)
+      oracle_databases | selectattr('oracle_db_name', 'equalto', opdb.0.cdb)
       | map(attribute='state') | list | first == 'present'
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
   become: true

diff --git a/roles/oradb_manage_parameters/tasks/main.yml b/roles/oradb_manage_parameters/tasks/main.yml
@@ -65,7 +65,7 @@
     - opdb.0.state == 'present'
     - opdb.1 is defined
     - >-
-      oracle_databases | selectattr('oracle_db_name', 'match', opdb.0.cdb)
+      oracle_databases | selectattr('oracle_db_name', 'equalto', opdb.0.cdb)
       | map(attribute='state') | list | first == 'present'
   become: true
   become_user: "{{ oracle_user }}"

diff --git a/roles/oradb_manage_profiles/tasks/main.yml b/roles/oradb_manage_profiles/tasks/main.yml
@@ -89,7 +89,7 @@
         - opdb.0.state == 'present'
         - opdb.1 is defined
         - >-
-          oracle_databases | selectattr('oracle_db_name', 'match', opdb.0.cdb)
+          oracle_databases | selectattr('oracle_db_name', 'equalto', opdb.0.cdb)
           | map(attribute='state') | list | first == 'present'
       run_once: "{{ _oraswgi_meta_configure_cluster }}"
       become: true

diff --git a/roles/oradb_manage_redo/tasks/main.yml b/roles/oradb_manage_redo/tasks/main.yml
@@ -17,22 +17,21 @@
         user: "{{ db_user }}"
         password: "{{ _db_password_cdb }}"
         mode: "{{ db_mode }}"
-        size: "{{ odb.0.redolog_size }}"
-        groups: "{{ odb.0.redolog_groups }}"
+        size: "{{ odb.redolog_size }}"
+        groups: "{{ odb.redolog_groups }}"
       environment: "{{ _oracle_env }}"
       run_once: "{{ _oraswgi_meta_configure_cluster }}"
-      loop:
-        - "{{ oracle_databases | flatten(levels=1) }}"
+      loop: "{{ oracle_databases }}"
       when:
         - oracle_databases is defined
-        - odb.0.redolog_size is defined
-        - odb.0.redolog_groups is defined
-        - odb.0.state == 'present'
+        - odb.redolog_size is defined
+        - odb.redolog_groups is defined
+        - odb.state == 'present'
       become_user: "{{ oracle_user }}"
       become: true
       loop_control:
         loop_var: odb
         label: >-
           service: {{ _db_service_name }}:{{ _listener_port_cdb }}
-          groups: {{ odb.0.redolog_groups }}
-          size: {{ odb.0.redolog_size }}
+          groups: {{ odb.redolog_groups | default('') }}
+          size: {{ odb.redolog_size | default('') }}
diff --git a/roles/oradb_manage_roles/tasks/main.yml b/roles/oradb_manage_roles/tasks/main.yml
@@ -54,7 +54,7 @@
     - opdb.0.state == 'present'
     - opdb.1 is defined
     - >-
-      oracle_databases | selectattr('oracle_db_name', 'match', opdb.0.cdb)
+      oracle_databases | selectattr('oracle_db_name', 'equalto', opdb.0.cdb)
       | map(attribute='state') | list | first == 'present'
   loop_control:
     loop_var: opdb