+
Skip to content

Conversation

bartowl
Copy link
Contributor

@bartowl bartowl commented Mar 4, 2024

This PR fixes many roles where loop: caused to evaluate only first element from oracle_databases / oracle_pdbs.
It also changes the match filter in probably all selectattr() calls as there exact match is needed, and match filter actually matches only beginning of the string/line thus creating a possibility to include also partial matches which would cause problems.
One last touch is change in oradb_facts role, as it used global fact variables and not those from registered variable, which (when using for example ignore_errors) might led to a situation where facts for one failed database would be set to those from previous loop element. It may never occur, yet this way it is just safer.

@bartowl
Copy link
Contributor Author

bartowl commented Mar 4, 2024

do not merge yet...

@bartowl bartowl marked this pull request as draft March 4, 2024 15:18
bartowl added 2 commits March 5, 2024 13:27
- replace match filter with equalto where applicable
@bartowl bartowl force-pushed the feature/oradb-facts-ignore-errors branch from 1045bef to c01f92a Compare March 5, 2024 12:29
@bartowl bartowl changed the title add option to ignore_errors on oradb_facts role fix loops Mar 5, 2024
@bartowl bartowl marked this pull request as ready for review March 5, 2024 17:16
@Rendanic Rendanic self-assigned this Mar 5, 2024
@Rendanic Rendanic added the bug label Mar 5, 2024
@Rendanic Rendanic added this to the 4.6 milestone Mar 5, 2024
@bartowl bartowl force-pushed the feature/oradb-facts-ignore-errors branch from c01f92a to 88cffef Compare March 6, 2024 08:33
@Rendanic
Copy link
Collaborator

Rendanic commented Mar 6, 2024

Big thanks for finding and fixing this bug!

@Rendanic Rendanic merged commit 15c0b8e into oravirt:master Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载