This repository was archived by the owner on Jan 24, 2025. It is now read-only.
Support for Node 14, the new LTS release #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paberr
approved these changes
Nov 17, 2020
2 tasks
mar-v-in
approved these changes
Feb 11, 2021
|
I re-enabled type-linting and Node-tests, they both work now (type-linting only for the pull_request job, as the fix for that is now merged into master). IMO we can disable tests for Node 12. I originally added them to demonstrate the regression in Node 14, but to not waste computing power, we can remove Node 12 and only run on v14, until v16 comes out. Wdyt? |
44a332a to
362fb87
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
What's in this pull request?
Update @nimiq/jungle-db dependency to its latest version, which includes an updated
node-lmdbversion that supports Node v14, which is the new LTS release since October 27, 2020.Without this update, @nimiq/core fails to install under Node v14.
This PR also includes a basic Github Actions workflow to test the install under both Node 12 and 14, to prove that before the update of
node-lmdbit didn't work. The workflow has the "Lint Types" and "Test Node/Browser" steps commented out, as the first currently fails (fixed in #569) and the tests fail because of CI timeout (I haven't investigated how to increase the timeout).