-
Notifications
You must be signed in to change notification settings - Fork 57
DIAMOND: only use READ1 for paired-end reads without merging #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c5dbc22
fix the diamond input channel for paired-end reads: update profileing.nf
LilyAnderssonLee 807201e
update CHANGELOG.md and profiling.nf
LilyAnderssonLee c333e35
Update CHNAGELOG.md
LilyAnderssonLee cc6efd9
Update docs/usage.md
LilyAnderssonLee c0503f5
Update subworkflows/local/profiling.nf
LilyAnderssonLee 95f7145
[automated] Fix code linting
nf-core-bot aebb15b
Update CHANGELOG.md
LilyAnderssonLee 9e6472f
Update docs/usage.md
LilyAnderssonLee b968520
Add more documnetation
jfy133 9ef1428
I think that is working now!
jfy133 9258417
Remove debugging dumps
jfy133 e2a3954
upate diamond input in the profiling.nf
LilyAnderssonLee d43b6b0
Merge branch 'dev' into diamond_input
sofstam 29fb01a
[automated] Fix code linting
nf-core-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfy133 I spotted the error.
filter
condition actually only allows single-end reads to proceed to DIAMOND analysis. I have tested this one and it should work now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops yes good catch!
I think the change makes sense, as we no-longer have to distinguish between single nor paired end (we just take R1 from paired end), so no filtering necessary 👍