+
Skip to content

Conversation

sofstam
Copy link
Collaborator

@sofstam sofstam commented Mar 11, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/taxprofiler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

sofstam and others added 30 commits January 15, 2025 10:50
Fix is a template change, see nf-core/tools#3416
If your pipeline is affected by this error I think it should be fine to manually apply this patch.
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Important! Template update for nf-core/tools v3.1.2
Important! Template update for nf-core/tools v3.2.0
Better docs for taxpasta related flags
Sort the input channel to ensure batches of input will remain constant across runs.
As suggested by @Midnighter, using toSortedList in place of collect improves clarity.

Also: [ suggested by @Midnighter ]
Remove closure argument to flatMap.  The operator with closure argument performed the default behavior of the operator without closure.
A samplesheet with both integer and non-numeric ( string ) values of sample caused type-mismatch error when compared.  Generate prefix string from meta and compare on prefix.
@jfy133
Copy link
Member

jfy133 commented Mar 11, 2025

Forgot version bump I think @sofstam 😬

@sofstam
Copy link
Collaborator Author

sofstam commented Mar 11, 2025

I realized it a bit late but I am updating the PR :)

Copy link

github-actions bot commented Mar 11, 2025

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 26d0721

+| ✅ 280 tests passed       |+
!| ❗  18 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
  • local_component_structure - krona_cleanup.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - kraken2_standard_report.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - shortread_preprocessing.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - standardisation_profiles.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - longread_filtering.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - profiling.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - shortread_hostremoval.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - visualization_krona.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - longread_adapterremoval.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - longread_preprocessing.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - shortread_adapterremoval.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - shortread_fastp.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - nonpareil.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - longread_hostremoval.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - shortread_complexityfiltering.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure

✅ Tests passed:

Run details

  • nf-core/tools version 3.2.0
  • Run at 2025-03-12 16:33:54

Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sofstam
Copy link
Collaborator Author

sofstam commented Mar 11, 2025

#584

@jfy133
Copy link
Member

jfy133 commented Mar 13, 2025

I can force merge because the conda overlapping errors are not related to the pipeline (an Nextflow issue)

@jfy133 jfy133 merged commit 970bdc2 into master Mar 13, 2025
97 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载