-
Notifications
You must be signed in to change notification settings - Fork 57
v1.2.3 - Bouncy Basenji Patch PR #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ofiler into bump_version_1.3.0
Post release bump version
Fix is a template change, see nf-core/tools#3416 If your pipeline is affected by this error I think it should be fine to manually apply this patch.
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Important! Template update for nf-core/tools v3.1.2
Important! Template update for nf-core/tools v3.2.0
Better docs for taxpasta related flags
Sort the input channel to ensure batches of input will remain constant across runs.
As suggested by @Midnighter, using toSortedList in place of collect improves clarity. Also: [ suggested by @Midnighter ] Remove closure argument to flatMap. The operator with closure argument performed the default behavior of the operator without closure.
Changelog for for #573
A samplesheet with both integer and non-numeric ( string ) values of sample caused type-mismatch error when compared. Generate prefix string from meta and compare on prefix.
Remove links to multiqc plots
Minor typo fixes
Sort input to krakenuniq to enable retrieval of cached batch runs. #570
Changelog post-3.1.2 and 3.2.0 template updates
Forgot version bump I think @sofstam 😬 |
I realized it a bit late but I am updating the PR :) |
|
erikrikarddaniel
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Prelease bump version
fix code blocks
Switch from using save_analysis_ready_reads to save_analysis_ready_fa…
LilyAnderssonLee
approved these changes
Mar 12, 2025
I can force merge because the conda overlapping errors are not related to the pipeline (an Nextflow issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).