+
Skip to content

Improve validation of run_accessions IDs within sample IDs #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2024
Merged

Improve validation of run_accessions IDs within sample IDs #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4726da5
Make input validation stricter to ensure run_accessions are unique wi…
jfy133 May 8, 2024
5ffcedf
Update CHANGELOG
jfy133 May 8, 2024
71328f8
[automated] Fix code linting
nf-core-bot May 8, 2024
c66dc4e
Merge branch 'dev' into improve-validation
jfy133 May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### `Fixed`

- [#484](https://github.com/nf-core/taxprofiler/pull/484) Improved input validation to immediately fail if run accession IDs within a given sample ID are not unique (❤️ to @sofstam for reporting, fixed by @jfy133)

### `Dependencies`

### `Deprecated`
Expand Down
1 change: 1 addition & 0 deletions assets/schema_input.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
},
"run_accession": {
"type": "string",
"unique": ["sample"],
"errorMessage": "Run accession must be provided and cannot contain spaces."
},
"instrument_platform": {
Expand Down
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载