Patch release: 1.1.6 #469
Merged
Patch release: 1.1.6 #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Bump up the pipeline version number in the dev branch
Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
… path and directory
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
remove commented code about unique db_name check
Replace the db_params:null into empty string "".
Add meta.single_end to ch_input.nanopore channel
Important! Template update for nf-core/tools v2.13.1
correct nanopore and fasta input channel - branch "dev"
|
bump the version
Fix download pipeline workflow
11 tasks
|
According to the these comments , the failing download-pipeline step will be ignore for now. |
maxulysse
approved these changes
Apr 15, 2024
or you can remove |
|
@maxulysse I'd prefer to leave it as is for now and address it in the next major release. |
sofstam
approved these changes
Apr 15, 2024
Remove |
|
@jfy133 Should I fix it with your suggestion before this merge? |
I think it would result in less changes that the current changes (but I can't really follow those changes 😬 ) But up to you! |
|
Personally I don't like merging when tests are failing, so either I fix it, or I disable it. |
Remove stub run in download_pipeline.yml
maxulysse
approved these changes
Apr 16, 2024
|
OK I think this would be OK now as Matthias says that there is no way around it until |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch release: 1.1.6
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).