+
Skip to content

Release version bump #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2023
Merged

Release version bump #412

merged 2 commits into from
Oct 27, 2023

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Oct 27, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/taxprofiler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 requested a review from a team October 27, 2023 03:17
@github-actions
Copy link

github-actions bot commented Oct 27, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 32d0d6e

+| ✅ 158 tests passed       |+
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.1.2
  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-27 04:46:50

@jfy133
Copy link
Member Author

jfy133 commented Oct 27, 2023

Gah forgot the changelog

@jfy133
Copy link
Member Author

jfy133 commented Oct 27, 2023

Woohoo, you CAN edit files from the gh app now!

@jfy133 jfy133 merged commit 73ec485 into dev Oct 27, 2023
@jfy133 jfy133 deleted the bump-version-for-release branch October 27, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthdsm matthdsm matthdsm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jfy133 @matthdsm
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载