+
Skip to content

bump version #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2023
Merged

bump version #402

merged 3 commits into from
Oct 12, 2023

Conversation

LilyAnderssonLee
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/taxprofiler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133
Copy link
Member

jfy133 commented Oct 11, 2023

How did you do this @LilyAnderssonLee ? With nf-core tools or manually?

@LilyAnderssonLee
Copy link
Contributor Author

@jfy133 Manually. I got an error by running nf-core bump-version 1.1.2dev
image

@jfy133
Copy link
Member

jfy133 commented Oct 12, 2023

Ok well you should always resolve the error rather than reverting to manual 😬

  1. You're missing the manifest update in nextflow.config
  2. The string in the multiQC config should just be /dev/ in the url

@jfy133
Copy link
Member

jfy133 commented Oct 12, 2023

And we don't bump the version in the workflow diagram for Dev versions

jfy133
jfy133 reviewed Oct 12, 2023
View reviewed changes
docs/images/taxprofiler_logo.svg
version="1.1"
id="svg5"
inkscape:version="1.1.1 (c3084ef, 2021-09-22)"
inkscape:version="1.1.2dev (c3084ef, 2021-09-22)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
inkscape:version="1.1.2dev (c3084ef, 2021-09-22)"
inkscape:version="1.1.1 (c3084ef, 2021-09-22)"

@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ca73d4d

+| ✅ 159 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-12 09:44:16

@jfy133 jfy133 merged commit bdf88d2 into nf-core:dev Oct 12, 2023
@LilyAnderssonLee
Copy link
Contributor Author

Thanks @jfy133
Sorry for a late reply. I am busy with clinical related things these days.
I agree with you that I should address the issues rather than manual corrections.

@jfy133
Copy link
Member

jfy133 commented Oct 13, 2023

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfy133 jfy133 jfy133 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LilyAnderssonLee @jfy133
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载