From 733a85e2bc13da62aacd23f8975462729dc78f7e Mon Sep 17 00:00:00 2001 From: mashehu Date: Wed, 11 Jun 2025 12:01:00 +0200 Subject: [PATCH] linting: fix type error --- nf_core/modules/modules_json.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/nf_core/modules/modules_json.py b/nf_core/modules/modules_json.py index 6a09a1aac4..79e9ee573a 100644 --- a/nf_core/modules/modules_json.py +++ b/nf_core/modules/modules_json.py @@ -1253,7 +1253,7 @@ def components_with_repos(): } ) - def recreate_dependencies(self, repo, org, subworkflow): + def recreate_dependencies(self, repo: str, org: str, subworkflow: Dict[str, str]) -> None: """ Try to recreate the installed_by entries for subworkflows. Remove self installation entry from dependencies, assuming that the modules.json has been freshly created, @@ -1268,19 +1268,21 @@ def recreate_dependencies(self, repo, org, subworkflow): name = dep_mod["name"] current_repo = dep_mod.get("git_remote", repo) current_org = dep_mod.get("org_path", org) + assert current_repo is not None and current_org is not None installed_by = self.modules_json["repos"][current_repo]["modules"][current_org][name]["installed_by"] if installed_by == ["modules"]: - self.modules_json["repos"][repo]["modules"][org][dep_mod]["installed_by"] = [] + self.modules_json["repos"][repo]["modules"][org][name]["installed_by"] = [] if sw_name not in installed_by: - self.modules_json["repos"][repo]["modules"][org][dep_mod]["installed_by"].append(sw_name) + self.modules_json["repos"][repo]["modules"][org][name]["installed_by"].append(sw_name) for dep_subwf in dep_subwfs: name = dep_subwf["name"] current_repo = dep_subwf.get("git_remote", repo) current_org = dep_subwf.get("org_path", org) + assert current_repo is not None and current_org is not None installed_by = self.modules_json["repos"][current_repo]["subworkflows"][current_org][name]["installed_by"] if installed_by == ["subworkflows"]: - self.modules_json["repos"][repo]["subworkflows"][org][dep_subwf]["installed_by"] = [] + self.modules_json["repos"][repo]["subworkflows"][org][name]["installed_by"] = [] if sw_name not in installed_by: - self.modules_json["repos"][repo]["subworkflows"][org][dep_subwf]["installed_by"].append(sw_name) + self.modules_json["repos"][repo]["subworkflows"][org][name]["installed_by"].append(sw_name) self.recreate_dependencies(repo, org, dep_subwf)