Use more pytest fixtures in modules tests #2226
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2226 +/- ##
==========================================
+ Coverage 73.02% 73.06% +0.04%
==========================================
Files 78 78
Lines 8384 8384
==========================================
+ Hits 6122 6126 +4
+ Misses 2262 2258 -4 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
|
||
|
|
||
| @pytest.fixture | ||
| def local_modules_repo(modules_repo_dummy, tmp_dir, pipeline_dir): |
There was a problem hiding this comment.
We will probably need to split it into separate fixtures. For the tests you have implemented we only need the modules repo, but for example to test installing modules we will need the installation objects.
There was a problem hiding this comment.
True. But normally I try to go a step as small as possible. Splitting it up will be a later step when it is needed.
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
|
I would start small and go step by step to gain experience with the fixtures in relation to side effects created by tools and git. Otherwise we'll end up with a big PR and if possible I'd like to avoid that. |
|
I added the WIP label, because it doesn't yet behave as I initially expected it to. While the return values of fixtures are fixed, side effects are not. There needs to be some other handling of this. I was lately looking into in-memory file systems to see if we could speed up by caching repo states in memory to speed up tests, but I haven't had the spare time required to investigate the options. One specific idea is to use pytest-pyfakefs. |
|
sounds good! will have a look to pyfakefs, thanks :) |
|
🧹 spring cleaning message 🌷 What is the state of this PR? Are there plans to continue working on it? |
|
I like the approach, we are almost there now with our test classes, but using fixtures could even combine some of their code I guess. |
|
I do not plan to work on this any further. Anyone interested, feel free to take it over. |
This PR adds some fixtures to pytest via the
conftest.pyfile in the tests directory. They can then be reused throughout the test suite and as a proof of concept are applied here for some tests of the modules command.PR checklist
CHANGELOG.mdis updateddocsis updated