+
Skip to content

copy pre-commit-config.yaml using package_data #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

copy pre-commit-config.yaml using package_data #2099

wants to merge 1 commit into from

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Dec 6, 2022

Should fix #2097 copies it to site-packages not nf-core, but that also makes the code run 🙂

@mashehu mashehu requested a review from ewels December 7, 2022 08:32
@ewels
Copy link
Member

ewels commented Dec 7, 2022

This makes me nervous.. I'm a bit worried that this will cause more problems downstream.

Is there really no other way to do this?

ewels
ewels requested changes Dec 7, 2022
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer not to touch the site-packages folder until we have really explored all other possibilities. Very much a last resort.

  • Won't be removed on uninstall
  • Could clash with other installations

@mashehu mashehu mentioned this pull request Dec 7, 2022
Merged
@ewels ewels closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels requested changes

@matthdsm matthdsm matthdsm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mashehu @ewels @matthdsm
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载