+
Skip to content

Fix hide-progress bug #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Fix hide-progress bug #2022

merged 1 commit into from
Nov 15, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Nov 15, 2022

Follow on from PR #2016

Reported on Slack here.

Failing action run here.

Messed up the function keywords in #2016, this fixes it. Bug replicated locally and fixed locally.

To replicate with current dev in the modules repo, checked out with PR nf-core/modules#2512:

nf-core --hide-progress modules lint gatk4/preprocessintervals

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #2022 (e509347) into dev (fb80900) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2022   +/-   ##
=======================================
  Coverage   63.74%   63.74%           
=======================================
  Files          41       41           
  Lines        4913     4913           
=======================================
  Hits         3132     3132           
  Misses       1781     1781           
Impacted Files Coverage Δ
nf_core/__main__.py 59.36% <ø> (ø)
nf_core/modules/lint/__init__.py 82.88% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ewels ewels merged commit 162b86a into nf-core:dev Nov 15, 2022
@ewels ewels deleted the fix-hide-progress-bug branch November 15, 2022 14:26
@github-actions
Copy link
Contributor

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载