-
Notifications
You must be signed in to change notification settings - Fork 206
add documentation for excluding GitHub during pipeline creation #1772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -406,13 +406,14 @@ description: A cool pipeline | |||
author: me | |||
prefix: cool-pipes-company | |||
skip: | |||
- github | |||
- ci | |||
- github_badges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add a bit more intelligence to the code, that the template-readme checks for github
and github_badges
before adding them or can we assume that people would always select both anyway and this would not be a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, using only github
will also remove github_badges
and ci
, but not the other way around. Maybe adding a small sentence explaining that will be good.
Codecov Report
@@ Coverage Diff @@
## dev #1772 +/- ##
==========================================
- Coverage 69.25% 69.25% -0.01%
==========================================
Files 59 59
Lines 7146 7148 +2
==========================================
+ Hits 4949 4950 +1
- Misses 2197 2198 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -406,13 +406,14 @@ description: A cool pipeline | |||
author: me | |||
prefix: cool-pipes-company | |||
skip: | |||
- github | |||
- ci | |||
- github_badges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, using only github
will also remove github_badges
and ci
, but not the other way around. Maybe adding a small sentence explaining that will be good.
Add docs for #1766
PR checklist
CHANGELOG.md
is updateddocs
is updated