+
Skip to content

add documentation for excluding GitHub during pipeline creation #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 30, 2022

Conversation

mirpedrol
Copy link
Member

Add docs for #1766

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@mirpedrol mirpedrol requested a review from mashehu August 29, 2022 13:42
@@ -406,13 +406,14 @@ description: A cool pipeline
author: me
prefix: cool-pipes-company
skip:
- github
- ci
- github_badges
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a bit more intelligence to the code, that the template-readme checks for github and github_badges before adding them or can we assume that people would always select both anyway and this would not be a problem?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, using only github will also remove github_badges and ci, but not the other way around. Maybe adding a small sentence explaining that will be good.

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #1772 (a11e07e) into dev (4d24ba2) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head a11e07e differs from pull request most recent head a2111ba. Consider uploading reports for the commit a2111ba to get more accurate results

@@            Coverage Diff             @@
##              dev    #1772      +/-   ##
==========================================
- Coverage   69.25%   69.25%   -0.01%     
==========================================
  Files          59       59              
  Lines        7146     7148       +2     
==========================================
+ Hits         4949     4950       +1     
- Misses       2197     2198       +1     
Impacted Files Coverage Δ
nf_core/create.py 62.35% <33.33%> (-0.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -406,13 +406,14 @@ description: A cool pipeline
author: me
prefix: cool-pipes-company
skip:
- github
- ci
- github_badges
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, using only github will also remove github_badges and ci, but not the other way around. Maybe adding a small sentence explaining that will be good.

@mashehu mashehu merged commit 174a612 into nf-core:dev Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载