GitHub Actions: add TODO statement to encourage customisation #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
drpatelh
reviewed
Jan 27, 2020
| docker pull {{ cookiecutter.name_docker }}:dev && docker tag {{ cookiecutter.name_docker }}:dev {{ cookiecutter.name_docker }}:dev | ||
| - name: Run test | ||
| - name: Pull docker image | ||
| run: docker pull {{ cookiecutter.name_docker }}:dev && docker tag {{ cookiecutter.name_docker }}:dev {{ cookiecutter.name_docker }}:dev |
There was a problem hiding this comment.
Suggested change
| run: docker pull {{ cookiecutter.name_docker }}:dev && docker tag {{ cookiecutter.name_docker }}:dev {{ cookiecutter.name_docker }}:dev | |
| run: | |
There was a problem hiding this comment.
I think this is why the tests are failing. The docker command needs to be on its own line.
drpatelh
requested changes
Jan 27, 2020
| docker pull {{ cookiecutter.name_docker }}:dev && docker tag {{ cookiecutter.name_docker }}:dev {{ cookiecutter.name_docker }}:dev | ||
| - name: Run test | ||
| - name: Pull docker image | ||
| run: docker pull {{ cookiecutter.name_docker }}:dev && docker tag {{ cookiecutter.name_docker }}:dev {{ cookiecutter.name_docker }}:dev |
There was a problem hiding this comment.
I think this is why the tests are failing. The docker command needs to be on its own line.
drpatelh
approved these changes
Jan 27, 2020
|
Thanks! It's not so much that it needs to be on its own line, but more than it needs to be escaped - the command has a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI tests should probably be customised to run with different parameters. Added a
TODOstatement that should be flagged as a warning by the linting code to encourage this.