Template: Fix ANSI codes in summary log messages #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So if this is NF/groovy log specific, there is some hope that it'll be fixed at some point, and we can remove this hack? |
maxulysse
approved these changes
Jan 27, 2020
Hopefully! Though I doubt that this is a high priority. I had a look in the nextflow code for this a while back but couldn't figure out a fix. |
|
Yes, I did try this when you introduced the fix in the logo @ewels and I chose to persist in finding something that looks consistent with the rest of the stuff thats printed to screen. Anyhow, this is better than what we have currently so maybe we leave the issue open until we find a better fix? |
drpatelh
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should hopefully fix #442