nf-core · ramprasadn · Mar 17, 2025 · Mar 3, 2025 · Mar 3, 2025 · Mar 17, 2025
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### `Changed`
 
+- Changed for loop to each in create_pedigree_file [#683](https://github.com/nf-core/raredisease/pull/683)
+
 ### `Fixed`
 
 ### Parameters

diff --git a/modules/local/create_pedigree_file/main.nf b/modules/local/create_pedigree_file/main.nf
@@ -19,13 +19,12 @@ process CREATE_PEDIGREE_FILE {
 
     script:
     def case_name = samples[0].case_id
-    def out   = new File(case_name + ".ped")
     outfile_text = ['#family_id', 'sample_id', 'father', 'mother', 'sex', 'phenotype'].join('\\t')
     def samples_list = []
-    for(int i = 0; i<samples.size(); i++) {
-        def sample_name =  samples[i].sample
+    samples.each { sample ->
+        def sample_name =  sample.sample
         if (!samples_list.contains(sample_name)) {
-            outfile_text += "\\n" + [samples[i].case_id, sample_name, samples[i].paternal, samples[i].maternal, samples[i].sex, samples[i].phenotype].join('\\t')
+            outfile_text += "\\n" + [sample.case_id, sample_name, sample.paternal, sample.maternal, sample.sex, sample.phenotype].join('\\t')
             samples_list.add(sample_name)
         }
     }