+
Skip to content

Updating vcf2cytosure and tiddit cov #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 10, 2024
Merged

Updating vcf2cytosure and tiddit cov #470

merged 6 commits into from
Jan 10, 2024

Conversation

jemten
Copy link
Collaborator

@jemten jemten commented Jan 9, 2024

These modules where previously patched awaiting an update at nf-core modules.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@jemten jemten changed the base branch from master to dev January 9, 2024 16:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 4a20f49

+| ✅ 155 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in WorkflowRaredisease.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-raredisease_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-raredisease_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-10 13:35:19

@jemten jemten marked this pull request as ready for review January 9, 2024 17:13
@jemten jemten requested review from Lucpen and ramprasadn January 10, 2024 12:09
Lucpen
Lucpen approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@Lucpen Lucpen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one small question.

modules/nf-core/vcf2cytosure/vcf2cytosure.diff
Comment on lines -16 to -19
"""
- touch ${prefix}.xml
+ touch ${prefix}.cgh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be like that in the actual module too given the output?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the vcf2cytosure/main.nfalready contained this change. I had edited it manually and then added this diff file. That's why you see no update to the main file.

@jemten jemten merged commit a2e6812 into nf-core:dev Jan 10, 2024
@jemten jemten deleted the fixes branch January 10, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lucpen Lucpen Lucpen approved these changes

@ramprasadn ramprasadn Awaiting requested review from ramprasadn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jemten @Lucpen
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载