+
Skip to content

Fixes vep starting as many instances as the square of the number of scatters #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2023
Merged

Fixes vep starting as many instances as the square of the number of scatters #421

merged 3 commits into from
Sep 5, 2023

Conversation

ramprasadn
Copy link
Collaborator

PR checklist

Fixed #405

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Sep 4, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1ac1a48

+| ✅ 151 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-04 12:00:22

@ramprasadn ramprasadn marked this pull request as ready for review September 4, 2023 13:27
@ramprasadn ramprasadn mentioned this pull request Sep 4, 2023
Closed
@ramprasadn ramprasadn requested a review from jemten September 5, 2023 07:13
jemten
jemten approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@jemten jemten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ramprasadn ramprasadn merged commit 003e660 into nf-core:dev Sep 5, 2023
@ramprasadn ramprasadn deleted the issue405 branch September 5, 2023 07:47
@jemten jemten mentioned this pull request Sep 5, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jemten jemten jemten approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ramprasadn @jemten
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载