Add support for month/weekday callbacks in moment.fn.format #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, here is the file size increase. +59 min |
|
I don't think that we can accept this pull request if it doesn't have any tests for the second code branch. There are currently no languages that have these callbacks, so we could either write tests that add a callback and run it, or we could wait until the Russian changes are made. |
|
This PR is useless with the new formatter, but I did add the functionality in with another commit. I added unit tests as well with a dummy language, so at least we have coverage. Another language had reason to use these callbacks, so I though it would be good to merge in so TR and RU can write code against it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#312