Fix assertions for #139 #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 94.39% 94.46% +0.07%
==========================================
Files 25 25
Lines 464 470 +6
==========================================
+ Hits 438 444 +6
Misses 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pat-s
reviewed
Oct 20, 2022
README.md
Outdated
| | carsurvscore | Correlation-Adjusted coRrelation Survival Score | Surv | Integer, Numeric | [carSurv](https://cran.r-project.org/package=carSurv) , [mlr3proba](https://cran.r-project.org/package=mlr3proba) | NA | | ||
| | cmim | Minimal Conditional Mutual Information Maximization | Classif & Regr | Integer, Numeric, Factor, Ordered | [praznik](https://cran.r-project.org/package=praznik) | NA | | ||
| | correlation | Correlation | Regr | Integer, Numeric | stats | NA | | ||
| | disr | Double Input Symmetrical Relevance | Classif & Regr | Integer, Numeric, Factor, Ordered | [praznik](https://cran.r-project.org/package=praznik) | NA | |
There was a problem hiding this comment.
The README update sets a lot of values to NA. Is this caused by the PR or a general issue?
There was a problem hiding this comment.
I've updated the scripts to generate the table.
| library("mlr3filters") | ||
|
|
||
| task = tsk("pima") | ||
| task = tsk("sonar") |
There was a problem hiding this comment.
Pima contains missing values, most filters do not support this. This PR adds an assertion for this.
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issues outlined in #139.
The following assertions were missing or broken:
Assertion on correct task_type
Filter$task_typewas documented to take a scalar string, but in practice could have multiple values. Renamed totask_types(breaking change) and adjusted documentation. Assertion added toFilter$calculate().Assertion on non-missing values
Assertion added to
Filter$calculate().