- Improve PipeOpFilter docu #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
pat-s
requested changes
Aug 23, 2022
R/FilterMRMR.R
Outdated
| #' library("mlr3pipelines") | ||
| #' task = mlr3::tsk("spam") | ||
| #' | ||
| #' # Note: The filter.frac is selected randomly and should be tuned. |
There was a problem hiding this comment.
You can leave the "the" out here and in all other occasions, just use filter.frac (formatting the argument as code would also be nice).
R/FilterNJMIM.R
Outdated
| #' as.data.table(filter) | ||
| #' } | ||
| #' | ||
| #' if (mlr3misc::require_namespaces(c("mlr3pipelines", "MASS", "praznik"), quietly = TRUE)) { |
There was a problem hiding this comment.
What is exactly is {MASS} needed for in all the examples? Do we only need it in some?
There was a problem hiding this comment.
Ah sorry, I somehow though rpart was in MASS but it isn't.
README.md
Outdated
Comment on lines
68
to
69
| ## Warning in `[.data.table`(as.data.table(mlr_filters), , !c("param_set", : | ||
| ## column(s) not removed because not found: [param_set] |
Comment on lines
+140
to
+143
| In many cases filtering is only one step in the modeling pipeline. To | ||
| select features based on filter values, one can use | ||
| [`PipeOpFilter`](https://mlr3pipelines.mlr-org.com/reference/mlr_pipeops_filter.html) | ||
| from [mlr3pipelines](https://github.com/mlr-org/mlr3pipelines). |
There was a problem hiding this comment.
One sentence per line please :) (maybe worth checking your editor settings, it seems line breaks are enforced at 80 chrs?)
There was a problem hiding this comment.
Note that this is the md file generated from the Rmd
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
for some reason I cannot build the README.html because of a http error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.