+
Skip to content

several bugfixes #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

several bugfixes #5

wants to merge 4 commits into from

Conversation

375gnu
Copy link

@375gnu 375gnu commented Jul 14, 2012

These patches are from debian package.

dc31612: closes debian bug #600713
Allows Locale.current= accept a value of Locale::TagList (output of Locale.current)

7e496cd: fixes driver loading under $SAFE>0

0ef254f: fixes various bugs with charset handling, debian bugs #520181, #521169

cf17e51: fixes incorrect call to java.util.Locale.new in test/test_driver_jruby.rb

kou added a commit to ruby-gettext/locale that referenced this pull request Aug 22, 2012
@kou
java: fix wrong variant format
21f7057 
Fix the fourth report of mutoh#5.

Patch by Hleb Valoshka. Thanks!!!
kou added a commit to ruby-gettext/locale that referenced this pull request Aug 22, 2012
@kou
Fix wrong environment variable check
6ec43e9 
LC_CTYPES should be checked instead of LC_MESSAGES.

Fix the third report of mutoh#5.

Debian bug #520181:
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=520181

Patch by Hleb Valoshka. Thanks!!!
Rreported by Adeodato Simó. Thanks!!!
@kou
Copy link

kou commented Aug 22, 2012

Thanks for your patches.
I merged almost your patches at https://github.com/ruby-gettext/locale.
But I couldn't understand a problem that is described in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521169.
It seems that LANG=en is the problem not locale gem problem.
Could you describe me about the problem?

@375gnu
Copy link
Author

375gnu commented Aug 22, 2012

I don't know what I was thinking about #521169, but my patches have no relation to it :) It looks like current Driver::Posix doesn't sets LANG, and this bug is related only to 1.93.

@kou
Copy link

kou commented Aug 23, 2012

Thanks for your comment!
OK. I'll ignore #521169!

@375gnu
Copy link
Author

375gnu commented May 10, 2013

I've noticed only recently that you, kou, have changed LC_CTYPE into LC_CTYPES. That's not correct, change it back to LC_CTYPE. You may use this trivial patch from debian.

Also you haven't integrated this patch (it' a part of commit 0ef254f mentioned above ). Without it Locale.current.charset in C/POSIX locale returns nothing instead of ANSI_X3.4-1968.

And please enable issues reporting for your repository like you did for gettext.

kou added a commit to ruby-gettext/locale that referenced this pull request May 10, 2013
@kou
Fix wrong environment variable name
048cea0 
LC_CTYPES ->
LC_CTYPE

GitHub: mutoh#5

Patch by Hleb Valoshka. Thanks!!!
kou added a commit to ruby-gettext/locale that referenced this pull request May 10, 2013
@kou
Use the default charset when the first tag doesn't have charset
650d738 
Debian: #520181
GitHub: mutoh#5

Reported by Hleb Valoshka. Thanks!!!
@kou
Copy link

kou commented May 10, 2013

Thanks.
I've mereged your patches.

And please enable issues reporting for your repository like you did for gettext.

OK. I opened https://github.com/ruby-gettext/locale/issues.

@375gnu 375gnu mentioned this pull request Sep 15, 2013
Closed
375gnu pushed a commit to 375gnu/locale that referenced this pull request Sep 14, 2015
@kou
Merge pull request mutoh#5 from moguno/support_ruby22_windows
c9c39bf 
DL is obsolete on ruby 2.2.

Patch by moguno. Thanks!!!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@375gnu @kou
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载