Add signature for alloctypes #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, indeed the DSL spec is missing the alloctypes function. The GC proposal adds recursive types, so the definition becomes quite a bit more complicated than it still is in the function refs proposal: it has to first "roll up" the types, which substitutes the type indices internal to the recursion, and then it has to do a regular substitution for the others, which all must be defined before the recursion we currently looking at (hence the [0:x_i] on the right). I don't think there is a typo in the spec (other than the wrong bracket), but it is a bit hard to read in the way it's trying to avoid a recursion. Please see #40 for a more readable formulation. |
|
Thank you for the quick answer! Now, I get it. |
Alan-Liang
pushed a commit
to Alan-Liang/spectec
that referenced
this pull request
Sep 1, 2024
* Resume table syntax This patch changes the syntax of resume tables: ```wast (resume $ct (tag $t $h)) => (resume $ct (on $t $h)) (resume_throw $ct $e (tag $t $h)) => (resume_throw $ct $e (on $t $h)) ``` * Update examples * Update overview document * Update explainer document
rossberg
pushed a commit
that referenced
this pull request
Nov 7, 2024
rossberg
pushed a commit
that referenced
this pull request
Nov 7, 2024
Similar to WebAssembly.Memory (#39), the WebAssembly.Table constructor also needs an `index` argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am currently working on converting the DSL you wrote in wasm3 into AL to demonstrate the generality of the SpecTec approach. Fortunately, most of them seem to be converted well with just a few minor adjustments. However, one part that isn't converted properly is the
allocmodule, as there is no allocation for the type of module instance. Fortunately, just defining the signature of thealloctypesfunction was enough to successfully complete the conversion ofallocmodule.Now, I'm trying to define the body of thealloctypesfunction. But there is a typo in the gc proposal, making it hard to comprehend, and it is defined differently in function reference proposal. So, I'm having difficulty understanding howalloctype*should be defined. Could you please provide some guidance on the definition?(Perhaps 'alloctypes' is not a critical component for execution. If that's the case, please kindly inform me, and we can postpone its body.)