Fix release workflow #481
Merged
Fix release workflow #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses wheel building issues as described in #474. This PR combines the release.yml with the build_tests.yml. Now the same wheels used for testing are used in the release. The wheels are produced via the cibuildwheel action, but we skip the repair wheels step which remains problematic.
Additionally, an
__init__file is added to the EPANET binaries folder to help the package recognize them as modules. Replaced linux binaries with versions that were build with GCC 10, not sure if this is necessary though.Tests and documentation
The wheels pass the CI/CD tests and I was able to sucessfully install them on Google Collab and my personal machine (Ubuntu 22.04).
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.