Thinking about this it would be possible to have a trait for both capitalized and non-capitalized.

I don't like the idea of adding both capitalized and non-capitalized, it seems clunky and heavy-handed.

I think defines for the function names as you originally suggest is fine, and allows users to override the default naming convention of cereal in a useful way to avoid potential name clashes (what if save/load are existing methods in some classes and you'd like to rename them all to cereal_load, cereal_save etc? Or CerealLoad, CerealSave, or cerealLoad, cerealSave etc.)

I agree the define seems to make much more sense now. Do you want me to
make a patch?
On 6 Mar 2014 01:28, "M2tM" notifications@github.com wrote:

I don't like the idea of adding both capitalized and non-capitalized, it
seems clunky and heavy-handed.

I think defines for the function names as you originally suggest is fine,
and allows users to override the default naming convention of cereal in a
useful way to avoid potential name clashes (what if save/load are existing
methods in some classes and you'd like to rename them all to cereal_load,
cereal_save etc? Or CerealLoad, CerealSave, or cerealLoad, cerealSave etc.)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/60#issuecomment-36812064
.

Discussed this with @randvoorhies and we're fine with patching this in as #define.

Back from holiday now, so will have a patch ready soon.

I've patched this up. Created a new file macros.hpp because helpers.hpp was the lowest hanging fruit to have the macros in but it didn't seem right putting them in there. I'm happy to change this. Quite nice being able to look at the macros.hpp file to work out what you can customize, but that's up to you guys. Pretty sure I've caught all of the places that need to be converted but have a review and see if I've missed anything that you might know about.

This looks pretty good - I'm working on adding a new serialization method, load/save_minimal, and will pull this in when that is getting wrapped up.

Going to push out 1.0 pretty soon - this and most of the other issues you've brought up will be part of 1.1. After 1.0 goes out I'm going to take a short break before addressing anything else.

Thanks, good work on getting 1.0.0 out and I look forward to 1.1.0 😄

Merged into a new branch here: https://github.com/USCiLab/cereal/tree/mattyclarkson-capitalization.

Haven't done minimal functions yet.

Wondering if it is worth it to change the error messages to reference the defined names instead of our defaults.

It would be a good touch, but if you are jumping in deep enough to be
changing the macros for the function names then you probably have invested
enough effort to understand when something goes wrong!
On 26 Mar 2014 21:55, "Shane Grant" notifications@github.com wrote:

Merged into a new branch here:
https://github.com/USCiLab/cereal/tree/mattyclarkson-capitalization.

Haven't done minimal functions yet.

Wondering if it is worth it to change the error messages to reference the
defined names instead of our defaults.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/60#issuecomment-38745224
.

We'll see - if it makes the code look cluttered, and it probably would, I'll probably just leave the messages as they are now, given the point you made.

OK, up to you ;) Thanks for merging this into a working branch.
On 26 Mar 2014 22:05, "Shane Grant" notifications@github.com wrote:

We'll see - if it makes the code look cluttered, and it probably would,
I'll probably just leave the messages as they are now, given the point you
made.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/60#issuecomment-38746270
.