forked from musescore/MuseScore
-
Notifications
You must be signed in to change notification settings - Fork 0
test fluidsynth dls support macos #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
T-X
wants to merge
161
commits into
master
Choose a base branch
from
pr-fluidsynth-dls-support-macos
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update template style version
Text fix: hammer-on/pull-offs -> hammer-ons/pull-offs Missing letter 's'; it should be like in other similar cases. Greetings, Grzegorz
Skip breaths when searching for cutaway clefs
There might be docks whose visibility is controlled by the page model - meaning they are visible by default, but the page can override and hide them. As a result, there’s a mismatch in visibility, which matters for the dock system when building the page. The actual visibility will be restored later when the page state is restored.
If we mark it as a 4.6 file, the linking properties need to be written in the 4.6 format (using EIDs), otherwise it will load with broken links.
gp-import: simplified bend import logic, added tests
Update Guitar + Tab template
Attempt to fix musescore#27625: Undo-Redo span entire window vertically
When building MuseScore without NO_THREADS then there are a few, small build errors. This changes fixes them. Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Glib is required by the libInstPatch library, which is required by fluidsynth for DLS support. Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
The libInstPatch library is required by fluidsynth for DLS support. Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
We're going to add fluid instpatch / DLS support. To avoid adding many type specific lines for cleanup and iterators then switch to using the type generic handlers instead now. While at it also remove the redundant "if (settings)" check before the "delete_fluid_settings(settings)" call. This delete function will check if settings is non-null internally anyway. No functional change. Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Fluidsynth itself already has support for DLS (DownLoadable Sound). This adds the needed code to allow parsing DLS in MuseScore, too. Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
DownLoadable Sound files typically have the extension .dls. Now that the backend supports using DLS also allow loading the files with the according file extension. Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Currently, any channel 9 in a MIDI file is automatically added as a drum instead of a melodic track. Which generally is the correct thing to do, as this is how MIDI has it specified and standardized. This new option allows to disable this behaviour though. Which is especially useful when using DLS (DownLoadable Sound) as DLS has a per channel bit to specify if it is a drum or melodic track. Some extracted DLS files from N64 games, extracted via the N64 Soundbank Tool (https://github.com/jombo23/N64-Tools/tree/master/N64SoundbankTool) for instance, use a channel 9 and have the drum bit in DLS unset. So this option would be needed to play such files correctly. The ANMP media player (https://github.com/derselbst/ANMP) has a similar option. According to a disscussion on the FluidSynth issue tracker there apparently is no way to detect and fix such a conflict between DLS and MIDI automatically, hence such a manual option seems needed: FluidSynth/fluidsynth#1576 Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
0e0c6a8
to
b70bbdf
Compare
b70bbdf
to
427007c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.