+
Skip to content

exclude chrono default features #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2022
Merged

exclude chrono default features #950

merged 1 commit into from
Aug 13, 2022

Conversation

robjtede
Copy link
Contributor

@robjtede robjtede commented Aug 8, 2022 •
edited
Loading

in an effort to remove time v0.1 from the dep graph

also see SeaQL/sea-query#410

billy1624
billy1624 reviewed Aug 9, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @robjtede, thanks for the auditing! I would suggest pinning the version to ^0.4 insead of ^0

@baoyachi
Copy link
Contributor

suggestion use chrono version:^0.4.20, because: https://github.com/chronotope/chrono/releases/tag/v0.4.20

@robjtede
Copy link
Contributor Author

robjtede commented Aug 12, 2022 •
edited
Loading

similar to comments in SeaQL/sea-query#410 i would suggest maintainers do that in a separate PR

@tyt2y3 tyt2y3 merged commit 5dd2850 into SeaQL:master Aug 13, 2022
@robjtede robjtede deleted the x-chrono-def branch August 13, 2022 16:19
@tyt2y3
Copy link
Member

tyt2y3 commented Aug 13, 2022

suggestion use chrono version:^0.4.20, because: https://github.com/chronotope/chrono/releases/tag/v0.4.20

I changed now

@tyt2y3
Copy link
Member

tyt2y3 commented Aug 20, 2022 •
edited
Loading

https://github.com/SeaQL/sea-orm/releases/tag/0.9.2

~/sea-orm$ cargo tree|grep time
│   ├── iana-time-zone v0.1.44
│   ├── time v0.3.11
│   │   └── time-macros v0.2.4 (proc-macro)
├── time v0.3.11 (*)
├── time v0.3.11 (*)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 left review comments

Assignees

@robjtede robjtede

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robjtede @baoyachi @tyt2y3 @billy1624
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载