-
Notifications
You must be signed in to change notification settings - Fork 274
add tests for no-comma HWBs #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
qix-/color-string#76 qix/color-string#76 Huh that's really weird. That's definitely worked before :| It might be because I have a grandfathered-in username with a dangling hyphen. |
BTW, should we treat the current HWB output of As the https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/hwb documentation states, there should be no comma between the HWB parameters. Or adding a new option flag to allow users to strip the comma? |
Yep seems so. From https://drafts.csswg.org/css-color/#the-hwb-notation:
Emphasis mine. |
@Qix- Should I update the |
Yes please that'd be very helpful 🙏🏻 |
@Qix- I've created a pull request to https://github.com/Qix-/color-string/pull/84 to fix the output format. |
The follow-up PR of https://github.com/Qix-/color-string/pull/76.
Did you notice that your projects has no references from other projects? GitHub cannot recognize the issue and PR links from yours. I've reported this issue to them: https://github.com/orgs/community/discussions/170750 🤦