+
Skip to content

Conversation

LitoMore
Copy link
Collaborator

@LitoMore LitoMore commented Aug 30, 2025

The follow-up PR of https://github.com/Qix-/color-string/pull/76.

Did you notice that your projects has no references from other projects? GitHub cannot recognize the issue and PR links from yours. I've reported this issue to them: https://github.com/orgs/community/discussions/170750 🤦

@LitoMore LitoMore requested a review from Qix- August 30, 2025 17:27
@Qix-
Copy link
Owner

Qix- commented Aug 30, 2025

qix-/color-string#76

qix/color-string#76

Huh that's really weird. That's definitely worked before :| It might be because I have a grandfathered-in username with a dangling hyphen.

@LitoMore
Copy link
Collaborator Author

LitoMore commented Aug 30, 2025

Hmm, it may be a cache issue? The CI fails after I revert the version.
nvm, I mis-typed the version number.

BTW, should we treat the current HWB output of .hwb().string() as a bug?

As the https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/hwb documentation states, there should be no comma between the HWB parameters.

Or adding a new option flag to allow users to strip the comma?

@LitoMore LitoMore changed the title bump dependencies and add tests for no-comma HWBs add tests for no-comma HWBs Aug 30, 2025
@LitoMore LitoMore linked an issue Aug 30, 2025 that may be closed by this pull request
@Qix-
Copy link
Owner

Qix- commented Aug 31, 2025

Yep seems so.

From https://drafts.csswg.org/css-color/#the-hwb-notation:

There is no Web compatibility issue with hwb, which is new in this level of the specification, and so hwb() does not support a legacy color syntax that separates all of its arguments with commas. Using commas inside hwb() is an error.

Emphasis mine.

@LitoMore
Copy link
Collaborator Author

LitoMore commented Sep 11, 2025

@Qix- Should I update the .hwb().string() logic in the PR?

@Qix-
Copy link
Owner

Qix- commented Sep 12, 2025

Yes please that'd be very helpful 🙏🏻

@LitoMore
Copy link
Collaborator Author

@Qix- I've created a pull request to https://github.com/Qix-/color-string/pull/84 to fix the output format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载