This repository was archived by the owner on Jul 27, 2024. It is now read-only.
Update Facets to Polymer 2 #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to Polymer2 branch
|
After tensorflow/tensorboard#2392 is merged to master, I will update this PR's workspace reference to TB to the new HEAD of master before submitting this |
jimbojw
approved these changes
Jul 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Facets off of Polymer 1, onto Polymer 2.
Polymer deps pulled in through TensorBoard workspace rules.
Made minimal code changes to move from Polymer 1 to Polymer 2, as per upgrade guides.
Had to create plottable helpers in same manner as TensorBoard did to get plottable chart interactions to work correctly in Polymer 2.
Tested by:
Running all demos/tests to ensure functionality remains.