Updates to Polymer2 branch #181
Conversation
| @@ -23,7 +23,7 @@ | |||
|
|
|||
| <dom-module id='facets-overview-chart'> | |||
| <template> | |||
| <link rel="stylesheet" href="../../../tf-imports/plottable.css"> | |||
| <style include="plottable-style"></style> | |||
There was a problem hiding this comment.
where is plottable-style defined? through "@org_tensorflow_tensorboard//tensorboard/components/tf_imports:plottable"?
There was a problem hiding this comment.
style#include is a Polymer thing where you can specify name of the dom-module:
https://github.com/stephanwlee/tensorboard/blob/8837c95c5249ed7a643fd6bf5d47ba90125e6742/tensorboard/components/tf_imports/plottable.html#L29-L33
1: https://polymer-library.polymer-project.org/1.0/docs/devguide/styling
2: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/style
In this case, yes, it is referring to a dom-module defined inside the tf-imports/plottable.html
|
With the web-animations.html removal, the paper-dropdown elemens don't seem to work (can't select anything in a drop-down, can't dismiss the drop-down). Did you see this in tensorboard as well? |
TensorBoard will not expose the
plottable_js_css. Instead, Facets should use this syntax.The second commit contains removal of
web-animations.htmlwhich pulls in a polyfill for web-animation which seems to be very incompatible with the app. Note that importing neon-animation does not, by default, pull in the web-animations.html.