This repository was archived by the owner on Jul 27, 2024. It is now read-only.
changed default sprite size to 32 to work better with large datasets #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the default sprite size to 32 to fix issues that I was having facets crash when trying to display a dataset with 33 columns and 90k records. It was suggested by @jimbojw to set the sprite to 32 pixels, so here is the PR for that. The Issue (reported by me) is located here:
#115 (comment)
I tested the suggest change on my dataset (no longer crashes) and tested just this change locally on the default dataset in facets. Let me know if there is anything else I need to do.