-
Notifications
You must be signed in to change notification settings - Fork 17
switch CLI from fire
to jsonargparse
#371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
952efac
to
aba6335
Compare
…parse-optionals-as-positionals.zip
@mauvilsa thank you for the update, unfortunately, GH did not allow me to accept suggestions as they were mixed with deleted code... so could you pls do another minor edit somewhere so you will be a co-author? also have you seen this?
|
When merging, you can just add to the bottom of the commit message:
I guess you either need to install |
@mauvilsa seems to be working fine! When we can expect to have it released? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we can expect to have it released?
Very likely next week.
--------- Co-authored-by: Mauricio Villegas <5780272+mauvilsa@users.noreply.github.com>
--------- Co-authored-by: Mauricio Villegas <5780272+mauvilsa@users.noreply.github.com>
@mauvilsa i see some breaking changes in using CLI
https://github.com/Lightning-AI/pytorch-lightning/actions/runs/16721662326/job/47327278556?pr=21010 |
@Borda are you sure that jsonargparse has breaking changes? In the error I see |
Yeah, thank you for this prompt reply |
Before submitting
What does this PR do?
We have dropped Fire with other projects
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
📚 Documentation preview 📚: https://lit-utilities--371.org.readthedocs.build/en/371/