+
Skip to content

Conversation

Borda
Copy link
Collaborator

@Borda Borda commented Mar 5, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

We have dropped Fire with other projects

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.


📚 Documentation preview 📚: https://lit-utilities--371.org.readthedocs.build/en/371/

@github-actions github-actions bot added the ci/cd Continuous integration and delivery label Mar 7, 2025
@Borda
Copy link
Collaborator Author

Borda commented Mar 19, 2025

@mauvilsa thank you for the update, unfortunately, GH did not allow me to accept suggestions as they were mixed with deleted code... so could you pls do another minor edit somewhere so you will be a co-author?

also have you seen this?

src/lightning_utilities/cli/__main__.py:21: error: Cannot find implementation or library stub for module named "jsonargparse"  [import-not-found]
src/lightning_utilities/cli/__main__.py:21: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

@mauvilsa
Copy link
Contributor

@mauvilsa thank you for the update, unfortunately, GH did not allow me to accept suggestions as they were mixed with deleted code... so could you pls do another minor edit somewhere so you will be a co-author?

When merging, you can just add to the bottom of the commit message:

---------
Co-authored-by: Mauricio Villegas <5780272+mauvilsa@users.noreply.github.com>

also have you seen this?

src/lightning_utilities/cli/__main__.py:21: error: Cannot find implementation or library stub for module named "jsonargparse"  [import-not-found]
src/lightning_utilities/cli/__main__.py:21: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

I guess you either need to install jsonargparse when running mypy, or configure mypy in pyproject.toml with ignore_missing_imports = True or add a # type: ignore

@Borda Borda requested a review from mauvilsa March 20, 2025 10:41
@Borda
Copy link
Collaborator Author

Borda commented Mar 20, 2025

@mauvilsa seems to be working fine! When we can expect to have it released? :)

Copy link
Contributor

@mauvilsa mauvilsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we can expect to have it released?

Very likely next week.

Borda and others added 3 commits March 26, 2025 09:29
---------
Co-authored-by: Mauricio Villegas <5780272+mauvilsa@users.noreply.github.com>
---------
Co-authored-by: Mauricio Villegas <5780272+mauvilsa@users.noreply.github.com>
@Borda Borda marked this pull request as ready for review March 26, 2025 08:29
@Borda Borda merged commit 9e88903 into main Mar 26, 2025
58 checks passed
@Borda Borda deleted the jsonargparse branch March 26, 2025 09:57
@Borda
Copy link
Collaborator Author

Borda commented Aug 4, 2025

@mauvilsa i see some breaking changes in using CLI

usage: find-unused-caches.py [-h] [--config CONFIG] [--print_config �[=flags]]
                             [--age_days AGE_DAYS] [--output_file OUTPUT_FILE]
                             repository token [age_days [output_file]]

note: extra positionals are parsed as optionals in the order shown above.
error: Unrecognized arguments: --repository=Lightning-AI/pytorch-lightning --token=***

https://github.com/Lightning-AI/pytorch-lightning/actions/runs/16721662326/job/47327278556?pr=21010

@mauvilsa
Copy link
Contributor

mauvilsa commented Aug 4, 2025

@Borda are you sure that jsonargparse has breaking changes? In the error I see --repository=Lightning-AI/pytorch-lightning --token=*** which shows that the arguments were not given as positional. The repository and token arguments are positional only. For these to also be accepted as non-positional, the CLI should be run as auto_cli(main, as_positional=False).

@Borda Borda mentioned this pull request Aug 4, 2025
3 tasks
@Borda
Copy link
Collaborator Author

Borda commented Aug 4, 2025

the CLI should be run as auto_cli(main, as_positional=False)

Yeah, thank you for this prompt reply

@Borda Borda mentioned this pull request Aug 4, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Continuous integration and delivery dependencies package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载