+
Skip to content

Reduce log pollution of failed Metadata fetch #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

abbas1902
Copy link
Collaborator

@abbas1902 abbas1902 commented Jun 17, 2025

Recently we optionally supported the use of mounting a Slurm bucket as well as using DNS zones for the Slurm controller. These are currently being passed as metadata and if they are not found we intend to log as such. We previously logged it as a log.exception which would be surfaced similarly as fatal errors (despite it being non-consequential). To reduce potential confusion when this is propagated to setup.log/slurmsync.log we will reduce the severity of this log to a warning so it is clear it is a non-fatal error and should server more as a notice for users.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 marked this pull request as ready for review June 17, 2025 18:31
@abbas1902 abbas1902 requested review from samskillman and a team as code owners June 17, 2025 18:31
@abbas1902 abbas1902 added the release-chore To not include into release notes label Jun 17, 2025
@RachaelSTamakloe RachaelSTamakloe self-requested a review June 17, 2025 18:51
@abbas1902 abbas1902 merged commit 51c51f2 into GoogleCloudPlatform:main Jun 17, 2025
19 of 76 checks passed
@abbas1902 abbas1902 deleted the hotfixv.1.55 branch June 17, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载