Reduce log pollution of failed Metadata fetch #4290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we optionally supported the use of mounting a Slurm bucket as well as using DNS zones for the Slurm controller. These are currently being passed as metadata and if they are not found we intend to log as such. We previously logged it as a
log.exception
which would be surfaced similarly as fatal errors (despite it being non-consequential). To reduce potential confusion when this is propagated tosetup.log/slurmsync.log
we will reduce the severity of this log to a warning so it is clear it is a non-fatal error and should server more as a notice for users.Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.