+
Skip to content

Update 06-story.yml #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

Update 06-story.yml #71

merged 2 commits into from
Jul 14, 2025

Conversation

gstout52
Copy link
Contributor

@gstout52 gstout52 commented Jul 9, 2025

Description

Added Rationale section to Story template

Related Issue(s)

N/A

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@gstout52 gstout52 requested a review from knolleary July 9, 2025 17:27
@@ -17,11 +17,14 @@ body:
label: Description
description: Describe the story
value: |
**As a:**
**As a _____ I want to _____ so that _____**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, not in favour of this part of the change. In the existing template, the three statements are separate lines that can be completed. The proposed change is less clear to me how to fill it in. I won't block the PR for it, so we can get the Rationale added, but would suggest reconsidering.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. Reverted.

Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but not 100% sure about changing the description field. Have provided feedback - but will let you decide.

…dback

As requested by Nick O'Leary, reverting the description format from the single-line template back to the three separate lines format which is clearer and easier to fill out.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@gstout52 gstout52 merged commit 273c643 into main Jul 14, 2025
@gstout52 gstout52 deleted the update-story-template branch July 14, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载