Fail only on error messages in stderr output stream for cloneRepo command
#970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonni
added a commit
that referenced
this pull request
Dec 7, 2022
… command (#970) * Throw error on non-existent parent directory for cloneRepo parameter * Default to true on cloneRepo when no error messages are found in stderr output stream * Remove defined by never used `isDefined`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes default behavior of
cloneRepoto returntrueunless thestderroutput stream contains error or warning messages besides theCloning into '.*'...pattern indicated for successful cloning.This PR resolves #968, and signifies the following version changes (per Semantic Version):
Changes:
This PR makes the following changes:
stderroutput stream ofgit clonecommand incloneRepoto determine if error or warning messages besides theCloning into '.*'...pattern appeared (which would indicate a failed clone operation).ENOENTerror on non-existent parent directory fordirparameter tocloneRepoChecklist:
Before submitting this PR, I have verified that my code:
fix/orfeature/branch that was initially branched off fromdevelopment.yarn lint) and unit testing (yarn test).yarn package).